Skip to content

Commit 22fd1da

Browse files
Alexander Yermolovichroyitaqi
authored andcommitted
[lldb][roar] Enable JITLoadList creation with minidump.
Summary: Remove override for Process::GetJITLoaders(), so that it will be invoked to create JITLoader::LoadPlugins. This is needed for minidump debugging of ROAR produced binaries. Test Plan: main.cpp -- P1888415270 helper.cpp -- P1888415793 build.sh -- P1888416364 commandsPGO.txt -- P1888416975 ``` ROAR_RUN_IN_PROCESS= ROAROPTS="--sampled-instr-burst-duration=65536" /home/ayermolo/local/roar-17/build/Release/fbcode-x86_64/toolchain/bin/lldb --source commandsPGO.txt mainJit.exe /home/ayermolo/local/roar-17/build/Release/fbcode-x86_64/toolchain/bin/lldb -c core.lldb mainJit.exe ``` ``` lldb process save-core -s=mixed-memory /home/ayermolo/local/tasks/T231371260/smallRepro/core.lldb ``` {F1980819973} Rollback Plan: Reviewers: jalalonde, #roar-jit, #lldb_team, ottoni Reviewed By: jalalonde Differential Revision: https://phabricator.intern.facebook.com/D79398101 Tasks: T227540238 (cherry picked from commit 3fffac6dba33d9d4efc3468c367800f7d5bcc0ff)
1 parent 54922d4 commit 22fd1da

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "lldb/Interpreter/OptionArgParser.h"
2323
#include "lldb/Interpreter/OptionGroupBoolean.h"
2424
#include "lldb/Target/DynamicLoader.h"
25-
#include "lldb/Target/JITLoaderList.h"
2625
#include "lldb/Target/MemoryRegionInfo.h"
2726
#include "lldb/Target/SectionLoadList.h"
2827
#include "lldb/Target/Target.h"
@@ -601,17 +600,6 @@ bool ProcessMinidump::GetProcessInfo(ProcessInstanceInfo &info) {
601600
return true;
602601
}
603602

604-
// For minidumps there's no runtime generated code so we don't need JITLoader(s)
605-
// Avoiding them will also speed up minidump loading since JITLoaders normally
606-
// try to set up symbolic breakpoints, which in turn may force loading more
607-
// debug information than needed.
608-
JITLoaderList &ProcessMinidump::GetJITLoaders() {
609-
if (!m_jit_loaders_up) {
610-
m_jit_loaders_up = std::make_unique<JITLoaderList>();
611-
}
612-
return *m_jit_loaders_up;
613-
}
614-
615603
#define INIT_BOOL(VAR, LONG, SHORT, DESC) \
616604
VAR(LLDB_OPT_SET_1, false, LONG, SHORT, DESC, false, true)
617605
#define APPEND_OPT(VAR) \

lldb/source/Plugins/Process/minidump/ProcessMinidump.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ class ProcessMinidump : public PostMortemProcess {
103103
llvm::StringRef name,
104104
lldb_private::ModuleSpec module_spec);
105105

106-
JITLoaderList &GetJITLoaders() override;
107-
108106
private:
109107
lldb::DataBufferSP m_core_data;
110108
llvm::ArrayRef<minidump::Thread> m_thread_list;

0 commit comments

Comments
 (0)