You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revert "[lldb-dap] Ensure we acquire the SB API lock while handling requests. (llvm#137026)"
Summary:
This reverts commit 3b48e2a.
Because this commit caused deadlock between DAP's main loop and the `EventThread()` who are running on different thread and could both obtain the mutex
Test Plan:
~~CI the TestDAP_reuseAdapter.py should pass~~
Guess there's no CI
```
[[email protected] ~/llvm-sand/build/Debug/fbcode-x86_64/toolchain]$ bin/llvm-lit ~/llvm-s
and/external/llvm-project/lldb/test/API/tools/lldb-dap/reuseDAP/TestDAP_reuseAdapter.py
-- Testing: 1 tests, 1 workers --
PASS: lldb-api :: tools/lldb-dap/reuseDAP/TestDAP_reuseAdapter.py (1 of 1)
Testing Time: 7.98s
Total Discovered Tests: 1
Passed: 1 (100.00%)
```
Rollback Plan:
Reviewers: alexandreperez, #lldb_team, peix
Reviewed By: alexandreperez
Subscribers: pdepetro, #lldb_team
Differential Revision: https://phabricator.intern.facebook.com/D78522146
0 commit comments