Skip to content

Commit ee55b2a

Browse files
dmpotskusmour
authored andcommitted
Disable the ProtocolMCP tests.
Summary: We get a build error that `lldb/Host/JSONTransport.h` is missing. That's due to D77191008. We might as well remove the ProtocolMCPServerTest.cpp test altogether, because lldb/Host/JSONTransport.h is part of a major DAP/MCP rewrite that we don't have, including it would be a major endeavor. Test Plan: `ninja check-lldb` Failures: P1867507908 Expected failures: [failing_unresolved_tests.txt](https://www.internalfb.com/code/osmeta-infrastructure-toolchain-build/tools/scripts/sand/filter_check_lldb_results/failing_unresolved_tests.txt) Rollback Plan: Reviewers: alexandreperez Reviewed By: alexandreperez Subscribers: pdepetro, #lldb_team Differential Revision: https://phabricator.intern.facebook.com/D78276515
1 parent ccff927 commit ee55b2a

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lldb/unittests/CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,12 @@ add_subdirectory(Thread)
7979
add_subdirectory(ValueObject)
8080

8181
if(LLDB_ENABLE_PROTOCOL_SERVERS)
82-
add_subdirectory(Protocol)
82+
# META: Disable this test for now.
83+
# We get a build error that lldb/Host/JSONTransport.h is missing.
84+
# That's due to D77191008. We might as well remove the ProtocolMCPServerTest.cpp test altogether,
85+
# because lldb/Host/JSONTransport.h is part of a major DAP/MCP rewrite that we don't have,
86+
# including it would be a major endeavor.
87+
# add_subdirectory(Protocol)
8388
endif()
8489

8590
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT LLDB_USE_SYSTEM_DEBUGSERVER)

0 commit comments

Comments
 (0)