Admin confirmation mail can be confirmed by the user

[SicorDev]

The default sender address for the admin confirmation mail is the user mail address. If the domain of this email uses SPF in "Fail" mode, the mail will be rejected and a non delivery notification is sent to the user.

Now the user can confirm the admin mail himself.

femanager/Classes/Controller/NewController.php

Lines 300 to 330 in eb25eec

	protected function createAdminConfirmationRequest(User $user)
	{
	$aacService = $this->objectManager->get(
	AutoAdminConfirmationService::class,
	$user,
	$this->settings,
	$this->contentObject
	);
	if ($aacService->isAutoAdminConfirmationFullfilled()) {
	$user->setDisable(false);
	$this->signalSlotDispatcher->dispatch(__CLASS__, __FUNCTION__ . 'AutoConfirmation', [$user, $this]);
	$this->createAllConfirmed($user);
	} else {
	$this->signalSlotDispatcher->dispatch(__CLASS__, __FUNCTION__ . 'ManualConfirmation', [$user, $this]);
	$this->sendMailService->send(
	'createAdminConfirmation',
	StringUtility::makeEmailArray(
	$this->settings['new']['confirmByAdmin'],
	$this->settings['new']['email']['createAdminConfirmation']['receiver']['name']['value']
	),
	StringUtility::makeEmailArray($user->getEmail(), $user->getUsername()),
	'New Registration request',
	[
	'user' => $user,
	'hash' => HashUtility::createHashForUser($user)
	],
	$this->config['new.']['email.']['createAdminConfirmation.']
	);
	$this->addFlashMessage(LocalizationUtility::translate('createRequestWaitingForAdminConfirm'));
	}
	}

[SicorDev]

This issue still exists in the current version. FEManager should not send mails from the user mail address. Please change the sender address to a constant.

[manuelportela]

@SicorDev make sure to set both (as stated in the setup.typoscript): email and name in order to trigger the override of these values. See overwriteEmailSender in SendMailService.

plugin.tx_femanager.settings.new.email.createAdminConfirmation.sender.email.value = no-reply@sender.email
plugin.tx_femanager.settings.new.email.createAdminConfirmation.sender.name.value = Sender Name

Be aware that these values must be overridden for all cases you actually use like createUserNotify, createAdminConfirmation.

I hope this helps you and others. I took me some time to walk down the whole path.

@sbusemann IMHO it's not a good idea to default to the users email as sender since this may lead to underlivered emails due to spf. If you want the users email as usability feature the reply-to header may be a better choice.
Anyways: I may not gasp what you guys were looking at when implementing this. I'm very thankful for all the work you put into this extension.

[SicorDev]

@manuelportela
Thanks, that's a possible workaround for now.

We would really appreciate, if the powermail developers would look into SPF and change the default implementation so its standard compliant.

[sbusemann]

@SicorDev you can provide a Pull request or ask for a quote: https://www.in2code.de/agentur/typo3-extensions/femanager/

Otherwise "The developers" will work on it, when they find time in their sparetime or if a customer of the Developers wants that to have fixed.

[SicorDev]

@SicorDev you can provide a Pull request or ask for a quote: https://www.in2code.de/agentur/typo3-extensions/femanager/

Otherwise "The developers" will work on it, when they find time in their sparetime or if a customer of the Developers wants that to have fixed.

For which branch do you want the pull request developed? main/develop/eap ? I assume you'll then merge it everywhere else?