Merge branch 'release/41.1.1'

einpraegsam · einpraegsam · commit a0191c8a890a · 2026-01-06T20:27:18.000+01:00
diff --git a/Classes/Domain/Repository/PagevisitRepository.php b/Classes/Domain/Repository/PagevisitRepository.php
@@ -4,7 +4,6 @@
 namespace In2code\Lux\Domain\Repository;
 
 use DateTime;
-use Doctrine\DBAL\Driver\Exception as ExceptionDbalDriver;
 use Doctrine\DBAL\Exception as ExceptionDbal;
 use Exception;
 use In2code\Lux\Domain\Model\Categoryscoring;
@@ -47,7 +46,6 @@ class PagevisitRepository extends AbstractRepository
      * @return array
      * @throws ExceptionDbal
      * @throws Exception
-     * @throws ExceptionDbalDriver
      */
     public function findCombinedByPageIdentifier(FilterDto $filter, int $limit = 100): array
     {
@@ -56,7 +54,7 @@ public function findCombinedByPageIdentifier(FilterDto $filter, int $limit = 100
             . ' left join ' . Page::TABLE_NAME . ' p on p.uid = pv.page'
             . ' left join ' . Visitor::TABLE_NAME . ' v on v.uid = pv.visitor'
             . ' left join ' . Categoryscoring::TABLE_NAME . ' cs on v.uid = cs.visitor'
-            . ' where 1 '
+            . ' where pv.page > 0 '
             . $this->extendWhereClauseWithFilterSearchterms($filter, 'p')
             . $this->extendWhereClauseWithFilterTime($filter, true, 'pv')
             . $this->extendWhereClauseWithFilterSite($filter, 'pv')
@@ -328,7 +326,6 @@ public function findAmountPerPageAndVisitor(int $pageIdentifier, Visitor $visito
      * @param int $limit
      * @return array
      * @throws ExceptionDbal
-     * @throws ExceptionDbalDriver
      */
     public function getAmountOfReferrers(FilterDto $filter, int $limit = 100): array
     {
@@ -505,6 +502,7 @@ public function getReferrerCategoryAmounts(FilterDto $filter): array
      * @param FilterDto $filter
      * @return array
      * @throws Exception
+     * @throws ExceptionDbal
      */
     public function getDomainsWithAmountOfVisits(FilterDto $filter): array
     {
@@ -517,7 +515,7 @@ public function getDomainsWithAmountOfVisits(FilterDto $filter): array
             . $this->extendWhereClauseWithFilterScoring($filter, 'v')
             . $this->extendWhereClauseWithFilterCategoryScoring($filter, 'cs')
             . ' group by domain order by count desc';
-        return (array)$connection->executeQuery($sql)->fetchAllAssociative();
+        return $connection->executeQuery($sql)->fetchAllAssociative();
     }
 
     /**
@@ -529,6 +527,7 @@ public function getDomainsWithAmountOfVisits(FilterDto $filter): array
      * @param FilterDto $filter
      * @return array
      * @throws Exception
+     * @throws ExceptionDbal
      */
     public function getAllDomains(FilterDto $filter): array
     {
@@ -547,6 +546,7 @@ public function getAllDomains(FilterDto $filter): array
      * @param FilterDto $filter
      * @return array
      * @throws Exception
+     * @throws ExceptionDbal
      */
     public function getAllLanguages(FilterDto $filter): array
     {
@@ -567,6 +567,7 @@ public function getAllLanguages(FilterDto $filter): array
      * @param FilterDto $filter
      * @return int
      * @throws Exception
+     * @throws ExceptionDbal
      */
     public function findAbandonsForPage(int $pageIdentifier, FilterDto $filter): int
     {
diff --git a/Classes/Domain/Tracker/PageTracker.php b/Classes/Domain/Tracker/PageTracker.php
@@ -3,7 +3,6 @@
 declare(strict_types=1);
 namespace In2code\Lux\Domain\Tracker;
 
-use In2code\Lux\Domain\Model\Page;
 use In2code\Lux\Domain\Model\Pagevisit;
 use In2code\Lux\Domain\Model\Visitor;
 use In2code\Lux\Domain\Repository\PageRepository;
@@ -13,9 +12,6 @@
 use In2code\Lux\Utility\ObjectUtility;
 use Psr\EventDispatcher\EventDispatcherInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Extbase\Configuration\Exception\InvalidConfigurationTypeException;
-use TYPO3\CMS\Extbase\Persistence\Exception\IllegalObjectTypeException;
-use TYPO3\CMS\Extbase\Persistence\Exception\UnknownObjectException;
 
 class PageTracker
 {
@@ -33,61 +29,43 @@ public function __construct(
         $this->eventDispatcher = $eventDispatcher;
     }
 
-    /**
-     * @param Visitor $visitor
-     * @param array $arguments
-     * @return Pagevisit|null
-     * @throws IllegalObjectTypeException
-     * @throws InvalidConfigurationTypeException
-     * @throws UnknownObjectException
-     */
     public function track(Visitor $visitor, array $arguments): ?Pagevisit
     {
         $pageUid = (int)$arguments['pageUid'];
         $languageUid = (int)$arguments['languageUid'];
         $referrer = $arguments['referrer'];
+        $pagevisit = null;
         if ($this->isTrackingActivated($visitor, $pageUid)) {
-            $pagevisit = $this->getPageVisit($pageUid, $languageUid, $referrer, $visitor);
-            $visitor->addPagevisit($pagevisit);
-            $visitor->setVisits($visitor->getNumberOfUniquePagevisits());
-            $this->visitorRepository->update($visitor);
-            $this->visitorRepository->persistAll();
+            $pagevisit = $this->getPagevisit($pageUid, $languageUid, $referrer, $visitor);
+            if ($pagevisit !== null) {
+                $visitor->addPagevisit($pagevisit);
+                $visitor->setVisits($visitor->getNumberOfUniquePagevisits());
+                $this->visitorRepository->update($visitor);
+                $this->visitorRepository->persistAll();
+            }
             $this->eventDispatcher->dispatch(new PageTrackerEvent($visitor, $pagevisit, $arguments));
-            return $pagevisit;
         }
-        return null;
+        return $pagevisit;
     }
 
-    /**
-     * @param int $pageUid
-     * @param int $languageUid
-     * @param string $referrer
-     * @param Visitor $visitor
-     * @return Pagevisit
-     */
-    protected function getPageVisit(int $pageUid, int $languageUid, string $referrer, Visitor $visitor): Pagevisit
+    protected function getPagevisit(int $pageUid, int $languageUid, string $referrer, Visitor $visitor): ?Pagevisit
     {
-        /** @var Pagevisit $pageVisit */
-        $pageVisit = GeneralUtility::makeInstance(Pagevisit::class);
         $pageRepository = GeneralUtility::makeInstance(PageRepository::class);
-        /** @var Page $page */
         $page = $pageRepository->findByUid($pageUid);
-        $pageVisit
-            ->setPage($page)
-            ->setSite($this->siteService->getSiteIdentifierFromPageIdentifier($pageUid))
-            ->setLanguage($languageUid)
-            ->setReferrer($referrer)
-            ->setDomainAutomatically()
-            ->setVisitor($visitor);
-        return $pageVisit;
+        $pagevisit = null;
+        if ($page !== null) {
+            $pagevisit = GeneralUtility::makeInstance(Pagevisit::class);
+            $pagevisit
+                ->setPage($page)
+                ->setSite($this->siteService->getSiteIdentifierFromPageIdentifier($pageUid))
+                ->setLanguage($languageUid)
+                ->setReferrer($referrer)
+                ->setDomainAutomatically()
+                ->setVisitor($visitor);
+        }
+        return $pagevisit;
     }
 
-    /**
-     * @param Visitor $visitor
-     * @param int $pageUid
-     * @return bool
-     * @throws InvalidConfigurationTypeException
-     */
     protected function isTrackingActivated(Visitor $visitor, int $pageUid): bool
     {
         return $pageUid > 0 && $visitor->isNotBlacklisted() && $this->isTrackingActivatedInSettings();
@@ -97,7 +75,6 @@ protected function isTrackingActivated(Visitor $visitor, int $pageUid): bool
      * Check if tracking of pagevisits is turned on via TypoScript
      *
      * @return bool
-     * @throws InvalidConfigurationTypeException
      */
     protected function isTrackingActivatedInSettings(): bool
     {
diff --git a/Classes/ViewHelpers/Pagination/UriViewHelper.php b/Classes/ViewHelpers/Pagination/UriViewHelper.php
@@ -52,7 +52,7 @@ protected function getAction(): string
     {
         $controllerAction = $this->renderingContext->getControllerAction();
         $parts = explode('/', $controllerAction);
-        return strtolower($parts[1] ?? '');
+        return lcfirst($parts[1] ?? '');
     }
 
     protected function getController(): string
diff --git a/Documentation/Technical/Campaigns/AbTesting.md b/Documentation/Technical/Campaigns/AbTesting.md
@@ -14,7 +14,7 @@ So first of all choose a page that you want to test (this is A). Copy this page,
 change only a few things on this page (this is B).
 
 **Tipp:** For a meaningful test result you should consider not to change too much elements between two pages.
-If you want to learn if a green or a blue button is clicked more often, don't change anything else then the color of
+If you want to learn if a green or a blue button is clicked more often, don't change anything else than the color of
 this specific button.
 
 ##### Configuration
diff --git a/Documentation/Technical/Changelog/Index.md b/Documentation/Technical/Changelog/Index.md
@@ -9,6 +9,7 @@
 
 | Version    | Date       | State    | TYPO3         | Description                                                                                                                                                                                           |
 |------------|------------|----------|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 41.1.1     | 2026-01-06 | Bugfix   | `12.4 + 13.4` | Fix pagebrowser on some detail views in backend, don't create pagevisit entries for non-existing pages                                                                                                |
 | 41.1.0     | 2025-12-23 | Task     | `12.4 + 13.4` | CSS update for a better campaign layout                                                                                                                                                               |
 | 41.0.0     | 2025-12-18 | Task     | `12.4 + 13.4` | IP services were replaced (iplist.cc + ipapi.com with ipapi.is + ipapi.co) see for more details [IpAddresses.md](../../Privacy/IpAddresses.md)                                                        |
 | 40.0.1     | 2025-12-04 | Bugfix   | `12.4 + 13.4` | Don't add events on a-tags with downloads if there is already an linklistener event given                                                                                                             |
diff --git a/ext_emconf.php b/ext_emconf.php
@@ -4,7 +4,7 @@
     'description' => 'Living User Experience - LUX - the Marketing Automation tool for TYPO3.
         Turn your visitors to leads. Identification and profiling of your visitors within your TYPO3 website.',
     'category' => 'plugin',
-    'version' => '41.1.0',
+    'version' => '41.1.1',
     'author' => 'Alex Kellner',
     'author_email' => 'alexander.kellner@in2code.de',
     'author_company' => 'in2code.de',

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ protected function getAction(): string`
`52`	`52`	`{`
`53`	`53`	`$controllerAction = $this->renderingContext->getControllerAction();`
`54`	`54`	`$parts = explode('/', $controllerAction);`
`55`		`- return strtolower($parts[1] ?? '');`
	`55`	`+ return lcfirst($parts[1] ?? '');`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`protected function getController(): string`