Skip to content

Fixed render bugs in render_to_temporary_file #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed render bugs in render_to_temporary_file #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ff4d1
Fixed render bugs in render_to_temporary_file
authcode Nov 15, 2021
c05c7cc
Merge branch 'master' into master
maxpeterson Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions wkhtmltopdf/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,20 +314,16 @@ def render_to_temporary_file(template, context, request=None, mode='w+b',
try:
render = template.render
except AttributeError:
content = loader.render_to_string(template, context)
content = loader.render_to_string(template, context, request=request)
else:
if django.VERSION < (1, 8):
# If using a version of Django prior to 1.8, ensure ``context`` is an
# instance of ``Context``
if not isinstance(context, Context):
if request:
context = RequestContext(request, context)
else:
context = Context(context)
# Handle error when ``request`` is None
content = render(context)
else:
content = render(context, request)
# Ensure ``context`` is an instance of ``Context``
if not isinstance(context, Context):
if request:
context = RequestContext(request, context)
else:
context = Context(context)
content = render(context)

content = smart_str(content)
content = make_absolute_paths(content)

Expand Down