Skip to content

Commit aa0a2a4

Browse files
authored
IWF-774: Fix TestSignalWorkflowCadence test (#567)
1 parent 340b6a6 commit aa0a2a4

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

integ/signal_test.go

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,8 @@ func doTestSignalWorkflow(t *testing.T, backendType service.BackendType, config
113113
failTestAtHttpError(err, httpResp, t)
114114

115115
// Short wait for workflow update
116-
if config != nil {
117-
time.Sleep(2 * time.Second)
118-
}
116+
time.Sleep(2 * time.Second)
117+
119118
err = uclient.QueryWorkflow(context.Background(), &debugDump, wfId, "", service.DebugDumpQueryType)
120119
if err != nil {
121120
helpers.FailTestWithError(err, t)
@@ -133,6 +132,9 @@ func doTestSignalWorkflow(t *testing.T, backendType service.BackendType, config
133132
}).Execute()
134133
failTestAtHttpError(err, httpResp, t)
135134

135+
// Short wait for workflow update
136+
time.Sleep(2 * time.Second)
137+
136138
err = uclient.QueryWorkflow(context.Background(), &debugDump, wfId, "", service.DebugDumpQueryType)
137139
if err != nil {
138140
helpers.FailTestWithError(err, t)
@@ -157,6 +159,10 @@ func doTestSignalWorkflow(t *testing.T, backendType service.BackendType, config
157159
// see why in https://github.com/temporalio/temporal/issues/4801
158160
unhandledSignalVals = append(unhandledSignalVals, sigVal)
159161
}
162+
// Cadence seems to be slower to process; short sleep needed
163+
if *cadenceIntegTest {
164+
time.Sleep(100 * time.Millisecond)
165+
}
160166
reqRpc := apiClient.DefaultApi.ApiV1WorkflowRpcPost(context.Background())
161167
rpcResp, httpResp2, err2 := reqRpc.WorkflowRpcRequest(iwfidl.WorkflowRpcRequest{
162168
WorkflowId: wfId,
@@ -169,7 +175,10 @@ func doTestSignalWorkflow(t *testing.T, backendType service.BackendType, config
169175
assertions.Equal(
170176
map[string]iwfidl.ChannelInfo{signal.UnhandledSignalName: {Size: ptr.Any(int32(i + 1))}}, infos)
171177
}
172-
178+
// Cadence seems to be slower to process; short sleep needed
179+
if *cadenceIntegTest {
180+
time.Sleep(100 * time.Millisecond)
181+
}
173182
reqRpc := apiClient.DefaultApi.ApiV1WorkflowRpcPost(context.Background())
174183
rpcResp, httpResp2, err2 := reqRpc.WorkflowRpcRequest(iwfidl.WorkflowRpcRequest{
175184
WorkflowId: wfId,

0 commit comments

Comments
 (0)