Skip to content

Commit 70c0d9b

Browse files
try to improve code quality grade
1 parent 1749dd9 commit 70c0d9b

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

index_generator/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from jinja2.exceptions import TemplateNotFound
1010
from index_generator.models.entries import Entry
1111
from index_generator.models.exceptions import IndexGeneratorTemplateNotFound
12-
from . import *
12+
from . import APP_NAME, APP_URL, APP_VERSION
1313

1414
indexIgnore = ('index.html', 'images', 'favicon.ico')
1515

index_generator/models/exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ def __init__(self, message, hint='Something went wrong.'):
66

77
class IndexGeneratorTemplateNotFound(IndexGeneratorBaseException):
88
def __init__(self, message):
9-
return super().__init__(message, hint='Template folder does not exists or template file is not found.')
9+
super().__init__(message, hint='Template folder does not exists or template file is not found.')

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
'index_generator': ['templates/*/*']
1919
},
2020
include_package_data=True,
21-
url='https://github.com/BruceZhang1993',
21+
url=APP_URL,
2222
license='MIT',
2323
author='Bruce Zhang, Edward P',
2424
author_email='',

tests/test_entries.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def test_entry():
1212
entry = Entry('CODE_OF_CONDUCT.md', '.', base='/', human=False)
1313
assert entry.path == '/CODE_OF_CONDUCT.md'
1414
# assert entry.mime == 'text/markdown'
15-
assert type(entry.modified) is float
16-
assert type(entry.size) is int
15+
assert isinstance(entry.modified, float) is True
16+
assert isinstance(entry.size, int) is True
1717
assert entry.isDir is False
1818
assert entry.name == 'CODE_OF_CONDUCT.md'

tests/test_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
def test_app_version(capfd):
77
sys.argv = ['index_generator', '--version']
88
main()
9-
out, err = capfd.readouterr()
9+
out, _ = capfd.readouterr()
1010
assert out == APP_NAME + ' ' + APP_VERSION + ' ' + APP_URL + "\n"
1111
sys.argv = ['index_generator', '-V']
1212
main()
13-
out, err = capfd.readouterr()
13+
out, _ = capfd.readouterr()
1414
assert out == APP_NAME + ' ' + APP_VERSION + ' ' + APP_URL + "\n"

0 commit comments

Comments
 (0)