chore: remove a bunch of mypy comments

Author: alexfikl

arraycontext/container/__init__.py

@@ -299,8 +299,7 @@ def _serialize_ndarray_container(ary: numpy.ndarray) -> SerializedContainer:
 
 
 @deserialize_container.register(np.ndarray)
-# https://github.com/python/mypy/issues/13040
-def _deserialize_ndarray_container(  # type: ignore[misc]
+def _deserialize_ndarray_container(
         template: numpy.ndarray,
         serialized: SerializedContainer) -> numpy.ndarray:
     # disallow subclasses
@@ -309,8 +308,7 @@ def _deserialize_ndarray_container(  # type: ignore[misc]
 
     result = type(template)(template.shape, dtype=object)
     for i, subary in serialized:
-        # FIXME: numpy annotations don't seem to handle object arrays very well
-        result[i] = subary  # type: ignore[call-overload]
+        result[i] = subary
 
     return result
 

arraycontext/container/traversal.py

@@ -1,5 +1,3 @@
-# mypy: disallow-untyped-defs
-
 """
 .. currentmodule:: arraycontext
 
@@ -976,7 +974,6 @@ def unflatten(
         checking is performed on the unflattened array. Otherwise, these
         checks are skipped.
     """
-    # NOTE: https://github.com/python/mypy/issues/7057
     offset: int = 0
     common_dtype = None
 
@@ -1046,12 +1043,12 @@ def _unflatten(
                 # Checking strides for 0 sized arrays is ill-defined
                 # since they cannot be indexed
                 if (
-                    # Mypy has a point: nobody promised a .strides attribute.
+                    # pyright has a point: nobody promised a .strides attribute.
                     template_subary_c.strides != subary.strides  # pyright: ignore[reportAttributeAccessIssue]
                     and template_subary_c.size != 0
                 ):
                     raise ValueError(
-                            # Mypy has a point: nobody promised a .strides attribute.
+                            # pyright has a point: nobody promised a .strides attribute.
                             f"strides do not match template: got {subary.strides}, "  # pyright: ignore[reportAttributeAccessIssue]
                             f"expected {template_subary_c.strides}") from None
 

arraycontext/pytest.py

@@ -325,7 +325,7 @@ def pytest_generate_tests_for_array_contexts(
     if env_factory_string is not None:
         unique_factories = set(env_factory_string.split(","))
     else:
-        unique_factories = set(factories)               # type: ignore[arg-type]
+        unique_factories = set(factories)
 
     if not unique_factories:
         raise ValueError("no array context factories were selected")

test/testlib.py

@@ -114,8 +114,7 @@ def _serialize_dof_container(ary: DOFArray):
 
 
 @deserialize_container.register(DOFArray)
-# https://github.com/python/mypy/issues/13040
-def _deserialize_dof_container(  # type: ignore[misc]
+def _deserialize_dof_container(
         template, iterable):
     def _raise_index_inconsistency(i, stream_i):
         raise ValueError(
@@ -130,8 +129,7 @@ def _raise_index_inconsistency(i, stream_i):
 
 
 @with_array_context.register(DOFArray)
-# https://github.com/python/mypy/issues/13040
-def _with_actx_dofarray(ary: DOFArray, actx: ArrayContext) -> DOFArray:  # type: ignore[misc]
+def _with_actx_dofarray(ary: DOFArray, actx: ArrayContext) -> DOFArray:
     return type(ary)(actx, ary.data)
 
 # }}}
@@ -227,6 +225,5 @@ class Velocity3D(Velocity2D):
 
 
 @with_array_context.register(Velocity2D)
-# https://github.com/python/mypy/issues/13040
-def _with_actx_velocity_2d(ary, actx):  # type: ignore[misc]
+def _with_actx_velocity_2d(ary, actx):
     return type(ary)(ary.u, ary.v, actx)