Skip to content

Commit 7cb188f

Browse files
committed
add a couple of fixmes
1 parent aa0067c commit 7cb188f

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

meshmode/discretization/connection/opposite_face.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -521,6 +521,7 @@ def make_opposite_face_connection(actx, volume_to_bdry_conn):
521521

522522
# {{{ make_partition_connection
523523

524+
# FIXME: Consider adjusting terminology from local/remote to self/other.
524525
def make_partition_connection(actx, *, local_bdry_conn,
525526
remote_bdry_discr, remote_group_infos):
526527
"""

meshmode/distributed.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ def receive_mesh_part(self):
148148

149149
# {{{ remote group info
150150

151+
# FIXME: "Remote" is perhaps not the best naming convention for this. For example,
152+
# in a multi-volume context it may be used when constructing inter-partition
153+
# connections between two parts on the same rank.
151154
@dataclass
152155
class RemoteGroupInfo:
153156
inter_partition_adj_groups: List[InterPartitionAdjacencyGroup]

0 commit comments

Comments
 (0)