pint fixes

cradu · cradu · commit f9255d27f643 · 2024-08-28T08:28:41.000+03:00
diff --git a/src/Console/Commands/Hooks/BaseCodeAnalyzerPreCommitHook.php b/src/Console/Commands/Hooks/BaseCodeAnalyzerPreCommitHook.php
@@ -68,7 +68,7 @@ abstract class BaseCodeAnalyzerPreCommitHook implements CodeAnalyzerPreCommitHoo
     protected string $dockerContainer = '';
 
     /**
-     * @var Chunk size used for analyze
+     * Chunk size used for analyze
      */
     protected int $chunkSize = 100;
 
@@ -306,7 +306,7 @@ protected function validateAnalyzerInstallation(): self
         );
         $this->command->newLine();
 
-        throw new HookFailException();
+        throw new HookFailException;
     }
 
     /**
@@ -329,7 +329,7 @@ protected function validateConfigPath(string $path): self
         );
         $this->command->newLine();
 
-        throw new HookFailException();
+        throw new HookFailException;
     }
 
     /**
@@ -363,7 +363,7 @@ protected function suggestAutoFixOrExit(): bool
         $this->markPipelineFailed();
 
         if (config('git-hooks.stop_at_first_analyzer_failure')) {
-            throw new HookFailException();
+            throw new HookFailException;
         }
 
         return false;
diff --git a/src/Console/Commands/PreCommit.php b/src/Console/Commands/PreCommit.php
@@ -52,7 +52,7 @@ public function handle(): int
 
             if ($this->checkPipelineFailed()) {
                 $this->clearPipelineFailed();
-                throw new HookFailException();
+                throw new HookFailException;
             }
         } catch (HookFailException) {
             return 1;
diff --git a/src/Exceptions/HookFailException.php b/src/Exceptions/HookFailException.php
@@ -6,6 +6,4 @@
 
 use RuntimeException;
 
-class HookFailException extends RuntimeException
-{
-}
+class HookFailException extends RuntimeException {}
diff --git a/src/GitHooksServiceProvider.php b/src/GitHooksServiceProvider.php
@@ -39,6 +39,6 @@ public function register(): void
         // Automatically apply the package configuration
         $this->mergeConfigFrom(__DIR__.'/../config/git-hooks.php', 'laravel-git-hooks');
 
-        $this->app->singleton('laravel-git-hooks', fn () => new GitHooks());
+        $this->app->singleton('laravel-git-hooks', fn () => new GitHooks);
     }
 }
diff --git a/src/Traits/WithPipelineFailCheck.php b/src/Traits/WithPipelineFailCheck.php
@@ -12,7 +12,7 @@ protected function markPipelineFailed(): void
     {
         $tmpFile = $this->getPipelineFailedTempFile();
         if (touch($tmpFile) === false) {
-            throw new HookFailException();
+            throw new HookFailException;
         }
     }
 
diff --git a/tests/Features/Commands/Hooks/BaseCodeAnalyzerPreCommitHookTest.php b/tests/Features/Commands/Hooks/BaseCodeAnalyzerPreCommitHookTest.php
@@ -17,7 +17,7 @@
 
     $next = fn ($files) => 'passed';
 
-    $hook = new ConcreteBaseCodeAnalyzerFixture();
+    $hook = new ConcreteBaseCodeAnalyzerFixture;
     $result = $hook->handleCommittedFiles($changedFiles, $next);
     expect($result)->toBe('passed');
 });
@@ -28,7 +28,7 @@
 
     $next = fn ($files) => 'passed';
 
-    $hook = new ConcreteBaseCodeAnalyzerFixture();
+    $hook = new ConcreteBaseCodeAnalyzerFixture;
     $result = $hook->handleCommittedFiles($changedFiles, $next);
     expect($result)->toBe('passed');
 })->with('modifiedFilesList');
@@ -44,7 +44,7 @@ function ($configName, $nonExistentPathConfig, $preCommitHookClass, $listOfFixab
         GitHooks::shouldReceive('isMergeInProgress')->andReturn(false);
         GitHooks::shouldReceive('getListOfChangedFiles')->andReturn($listOfFixablePhpFiles);
 
-        $preCommitHook = new $preCommitHookClass();
+        $preCommitHook = new $preCommitHookClass;
         $this->artisan('git-hooks:pre-commit')
             ->expectsOutputToContain($preCommitHook->getName().' is not installed.')
             ->assertExitCode(1);
@@ -62,7 +62,7 @@ function ($configName, $nonExistentPathConfig, $preCommitHookClass, $listOfFixab
         GitHooks::shouldReceive('isMergeInProgress')->andReturn(false);
         GitHooks::shouldReceive('getListOfChangedFiles')->andReturn($listOfFixablePhpFiles);
 
-        $preCommitHook = new $preCommitHookClass();
+        $preCommitHook = new $preCommitHookClass;
         $this->artisan('git-hooks:pre-commit')
             ->expectsOutputToContain($preCommitHook->getName().' config file does not exist.')
             ->assertExitCode(1);
diff --git a/tests/Features/Commands/Hooks/EnlightnPreCommitHookTest.php b/tests/Features/Commands/Hooks/EnlightnPreCommitHookTest.php
@@ -22,7 +22,7 @@
 
     $next = fn ($files) => 'passed';
 
-    $hook = new EnlightnPreCommitHook();
+    $hook = new EnlightnPreCommitHook;
     $result = $hook->handle($changedFiles, $next);
     expect($result)->toBe('passed');
 });
@@ -44,7 +44,7 @@
     $command = $commands['git-hooks:pre-commit'];
 
     $input = new ArrayInput([]);
-    $output = new BufferedOutput();
+    $output = new BufferedOutput;
 
     $exitCode = $command->run($input, $output);
     $outputText = $output->fetch();
diff --git a/tests/Features/Commands/PostCommitTest.php b/tests/Features/Commands/PostCommitTest.php
@@ -40,7 +40,7 @@
     $postCommitHook1 = Mockery::mock(PostCommitHook::class);
     $postCommitHook1->expects('handle')
         ->andReturnUsing(function (Log $log, Closure $closure): never {
-            throw new HookFailException();
+            throw new HookFailException;
         });
 
     $this->config->set('git-hooks.post-commit', [
diff --git a/tests/Features/Commands/PreCommitTest.php b/tests/Features/Commands/PreCommitTest.php
@@ -44,7 +44,7 @@
     $preCommitHook1 = Mockery::mock(PreCommitHook::class);
     $preCommitHook1->expects('handle')
         ->andReturnUsing(function (ChangedFiles $files, Closure $closure): never {
-            throw new HookFailException();
+            throw new HookFailException;
         });
 
     $this->config->set('git-hooks.pre-commit', [
diff --git a/tests/Features/Commands/PrepareCommitMessageTest.php b/tests/Features/Commands/PrepareCommitMessageTest.php
@@ -45,7 +45,7 @@
     $postCommitHook1 = Mockery::mock(MessageHook::class);
     $postCommitHook1->expects('handle')
         ->andReturnUsing(function (CommitMessage $commitMessage, Closure $closure): never {
-            throw new HookFailException();
+            throw new HookFailException;
         });
 
     $this->config->set('git-hooks.prepare-commit-msg', [
diff --git a/tests/Fixtures/ClassWithRectorIssues.php b/tests/Fixtures/ClassWithRectorIssues.php
@@ -1,4 +1,4 @@
-<?php 
+<?php
 
 namespace Igorsgm\GitHooks\Tests\Fixtures;
 
@@ -9,9 +9,9 @@ class ClassWithRectorIssues
     protected function test()
     {
         $a = [];
-        
+
         if (empty($a)) {
-            $a = ["string", 'another string'];
+            $a = ['string', 'another string'];
         }
 
         return $a;
diff --git a/tests/Fixtures/ClassWithoutFixableIssues.php b/tests/Fixtures/ClassWithoutFixableIssues.php
@@ -2,6 +2,4 @@
 
 namespace Igorsgm\GitHooks\Tests\Fixtures;
 
-class ClassWithoutFixableIssues
-{
-}
+class ClassWithoutFixableIssues {}
diff --git a/tests/Fixtures/ConcreteBaseCodeAnalyzerFixture.php b/tests/Fixtures/ConcreteBaseCodeAnalyzerFixture.php
@@ -6,17 +6,9 @@
 
 class ConcreteBaseCodeAnalyzerFixture extends BaseCodeAnalyzerPreCommitHook
 {
-    public function analyzerCommand(): string
-    {
+    public function analyzerCommand(): string {}
 
-    }
+    public function fixerCommand(): string {}
 
-    public function fixerCommand(): string
-    {
-    }
-
-    public function handle(\Igorsgm\GitHooks\Git\ChangedFiles $files, \Closure $next): mixed
-    {
-
-    }
+    public function handle(\Igorsgm\GitHooks\Git\ChangedFiles $files, \Closure $next): mixed {}
 }
diff --git a/tests/Fixtures/HooksPipelineWithParamsFixture2.php b/tests/Fixtures/HooksPipelineWithParamsFixture2.php
@@ -7,9 +7,7 @@
 
 class HooksPipelineWithParamsFixture2 implements Hook
 {
-    public function __construct(private array $parameters)
-    {
-    }
+    public function __construct(private array $parameters) {}
 
     /**
      * Get hook name
diff --git a/tests/Fixtures/rectorFixture.php b/tests/Fixtures/rectorFixture.php
@@ -2,8 +2,8 @@
 
 declare(strict_types=1);
 
-use Rector\Config\RectorConfig;
 use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector;
+use Rector\Config\RectorConfig;
 
 return RectorConfig::configure()
     ->withPaths([
diff --git a/tests/Unit/HooksPipelineTest.php b/tests/Unit/HooksPipelineTest.php
@@ -5,7 +5,7 @@
 
 test('Data is sent through Pipes', function ($hook, ?array $parameters = null) {
     $parameters ??= [];
-    $container = new Container();
+    $container = new Container;
 
     $hookConfig = ! empty($parameters) ? [$hook => $parameters] : [$hook];
     $this->config->set('git-hooks.pre-commit', $hookConfig);
@@ -21,7 +21,7 @@
 })->with('pipelineHooks');
 
 test('Data is sent through Pipes with Closure', function () {
-    $container = new Container();
+    $container = new Container;
 
     $closureHook = function ($message, $next) {
         $message .= ' Hook 4';
diff --git a/tests/Unit/Traits/WithPipelineTest.php b/tests/Unit/Traits/WithPipelineTest.php
@@ -5,8 +5,8 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 test('Starts and Finishes Pipe Task with decorated output', function () {
-    $command = new PreCommit();
-    $hook = new PreCommitFixtureHook();
+    $command = new PreCommit;
+    $hook = new PreCommitFixtureHook;
     $outputMock = $this->createMock(OutputInterface::class);
 
     $outputMock->expects($this->once())

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function handle(): int`
`52`	`52`
`53`	`53`	`if ($this->checkPipelineFailed()) {`
`54`	`54`	`$this->clearPipelineFailed();`
`55`		`- throw new HookFailException();`
	`55`	`+ throw new HookFailException;`
`56`	`56`	`}`
`57`	`57`	`} catch (HookFailException) {`
`58`	`58`	`return 1;`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,6 @@ public function register(): void`
`39`	`39`	`// Automatically apply the package configuration`
`40`	`40`	`$this->mergeConfigFrom(__DIR__.'/../config/git-hooks.php', 'laravel-git-hooks');`
`41`	`41`
`42`		`- $this->app->singleton('laravel-git-hooks', fn () => new GitHooks());`
	`42`	`+ $this->app->singleton('laravel-git-hooks', fn () => new GitHooks);`
`43`	`43`	`}`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ protected function markPipelineFailed(): void`
`12`	`12`	`{`
`13`	`13`	`$tmpFile = $this->getPipelineFailedTempFile();`
`14`	`14`	`if (touch($tmpFile) === false) {`
`15`		`- throw new HookFailException();`
	`15`	`+ throw new HookFailException;`
`16`	`16`	`}`
`17`	`17`	`}`
`18`	`18`