.github/workflows/workspace.yml #1613
Annotations
6 errors and 20 warnings
|
build-and-test (stable, windows-2022, x86_64-pc-windows-msvc)
Process completed with exit code 1.
|
|
build-and-test (beta, windows-2022, x86_64-pc-windows-msvc)
Process completed with exit code 1.
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-oxidized-importer/src/lib.rs#L89
error: mutable borrow from immutable input(s)
--> python-oxidized-importer/src/lib.rs:89:56
|
89 | pub(crate) fn get_module_state(m: &PyModule) -> Result<&mut ModuleState, PyErr> {
| ^^^^^^^^^^^^^^^^
|
note: immutable borrow here
--> python-oxidized-importer/src/lib.rs:89:35
|
89 | pub(crate) fn get_module_state(m: &PyModule) -> Result<&mut ModuleState, PyErr> {
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#mut_from_ref
= note: `#[deny(clippy::mut_from_ref)]` on by default
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-oxidized-importer/src/lib.rs#L89
error: mutable borrow from immutable input(s)
--> python-oxidized-importer/src/lib.rs:89:56
|
89 | pub(crate) fn get_module_state(m: &PyModule) -> Result<&mut ModuleState, PyErr> {
| ^^^^^^^^^^^^^^^^
|
note: immutable borrow here
--> python-oxidized-importer/src/lib.rs:89:35
|
89 | pub(crate) fn get_module_state(m: &PyModule) -> Result<&mut ModuleState, PyErr> {
| ^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#mut_from_ref
= note: `#[deny(clippy::mut_from_ref)]` on by default
|
|
build-and-test (1.81.0, windows-2022, x86_64-pc-windows-msvc)
Process completed with exit code 1.
|
|
build-and-test (nightly, windows-2022, x86_64-pc-windows-msvc)
Process completed with exit code 1.
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L666
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:666:49
|
666 | let name_length = u16::try_from(name.as_bytes().len())
| ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L591
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:591:27
|
591 | u16::try_from(self.name.as_bytes().len()).context("converting name to u16")?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L424
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:424:21
|
424 | path.as_bytes().len()
| ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `path.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L402
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:402:45
|
402 | .map(|(key, value)| key.as_bytes().len() + path_bytes_length(value))
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L392
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:392:45
|
392 | .map(|(key, value)| key.as_bytes().len() + path_bytes_length(value))
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L348
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:348:42
|
348 | names.iter().map(|s| s.as_bytes().len()).sum()
| ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L333
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:333:45
|
333 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L323
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:323:45
|
323 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L281
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:281:36
|
281 | ResourceField::Name => self.name.as_bytes().len(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#needless_as_bytes
= note: `#[warn(clippy::needless_as_bytes)]` on by default
|
|
build-and-test (beta, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/parser.rs#L65
warning: variable does not need to be mutable
--> python-packed-resources/src/parser.rs:65:13
|
65 | let mut state = self.blob_sections[resource_field as usize]
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L666
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:666:49
|
666 | let name_length = u16::try_from(name.as_bytes().len())
| ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L591
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:591:27
|
591 | u16::try_from(self.name.as_bytes().len()).context("converting name to u16")?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L424
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:424:21
|
424 | path.as_bytes().len()
| ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `path.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L402
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:402:45
|
402 | .map(|(key, value)| key.as_bytes().len() + path_bytes_length(value))
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L392
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:392:45
|
392 | .map(|(key, value)| key.as_bytes().len() + path_bytes_length(value))
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L348
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:348:42
|
348 | names.iter().map(|s| s.as_bytes().len()).sum()
| ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L333
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:333:45
|
333 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L323
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:323:45
|
323 | .map(|(key, value)| key.as_bytes().len() + value.len())
| ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/writer.rs#L281
warning: needless call to `as_bytes`
--> python-packed-resources/src/writer.rs:281:36
|
281 | ResourceField::Name => self.name.as_bytes().len(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.name.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_as_bytes
= note: `#[warn(clippy::needless_as_bytes)]` on by default
|
|
build-and-test (stable, ubuntu-22.04, x86_64-unknown-linux-gnu):
python-packed-resources/src/parser.rs#L65
warning: variable does not need to be mutable
--> python-packed-resources/src/parser.rs:65:13
|
65 | let mut state = self.blob_sections[resource_field as usize]
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
|