Adjust implementation + add tests

Author: claudiodekker

src/Middleware.php

@@ -8,6 +8,11 @@
 
 class Middleware
 {
+    /**
+     * The root template that will be loaded on the first page visit.
+     *
+     * @var string
+     */
     protected $rootView = 'app';
 
     /**
@@ -59,7 +64,7 @@ public function handle(Request $request, Closure $next)
 
         Inertia::share($this->share($request));
 
-        Inertia::setRootView($this->rootView($request) ?? $this->rootView);
+        Inertia::setRootView($this->rootView($request));
 
         $response = $next($request);
         $response = $this->checkVersion($request, $response);
@@ -135,13 +140,14 @@ public function resolveValidationErrors(Request $request)
     }
 
     /**
-     * Ability to set the current root view.
+     * Sets the root template that will be loaded on the first page visit.
      *
+     * @see https://inertiajs.com/server-side-setup#root-template
      * @param Request $request
      * @return string
      */
     public function rootView(Request $request)
     {
-        return 'app';
+        return $this->rootView;
     }
 }

stubs/middleware.stub

@@ -32,15 +32,4 @@ class {{ class }} extends Middleware
             //
         ]);
     }
-
-    /**
-     * Ability to set the current root view.
-     *
-     * @param Request $request
-     * @return string
-     */
-    public function rootView(Request $request)
-    {
-        // return 'custom';
-    }
 }

tests/MiddlewareTest.php

@@ -9,6 +9,7 @@
 use Illuminate\Support\MessageBag;
 use Illuminate\Support\ViewErrorBag;
 use Inertia\Inertia;
+use Inertia\Middleware;
 use Inertia\Tests\Stubs\ExampleMiddleware;
 
 class MiddlewareTest extends TestCase
@@ -139,10 +140,39 @@ public function test_default_validation_errors_can_be_overwritten()
         ]);
     }
 
-    private function prepareMockEndpoint($version = null, $shared = [])
+    public function test_middleware_can_change_the_root_view_via_a_property()
     {
-        return Route::middleware(StartSession::class)->get('/', function (Request $request) use ($version, $shared) {
-            return (new ExampleMiddleware($version, $shared))->handle($request, function ($request) {
+        $this->prepareMockEndpoint(null, [], new class extends Middleware {
+            protected $rootView = 'welcome';
+        });
+
+        $response = $this->get('/');
+        $response->assertOk();
+        $response->assertViewIs('welcome');
+    }
+
+    public function test_middleware_can_change_the_root_view_by_overriding_the_rootview_method()
+    {
+        $this->prepareMockEndpoint(null, [], new class extends Middleware {
+            public function rootView(Request $request)
+            {
+                return 'welcome';
+            }
+        });
+
+        $response = $this->get('/');
+        $response->assertOk();
+        $response->assertViewIs('welcome');
+    }
+
+    private function prepareMockEndpoint($version = null, $shared = [], $middleware = null)
+    {
+        if (is_null($middleware)) {
+            $middleware = new ExampleMiddleware($version, $shared);
+        }
+
+        return Route::middleware(StartSession::class)->get('/', function (Request $request) use ($middleware) {
+            return $middleware->handle($request, function ($request) {
                 return Inertia::render('User/Edit', ['user' => ['name' => 'Jonathan']])->toResponse($request);
             });
         });