Merge pull request #60 from ledermann/fix-redirect

Fix compatibility with "responders" gem (and thus "devise")

Author: bknoles

inertia_rails.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rails-controller-testing"
   spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "appraisal"
+  spec.add_development_dependency "responders"
 end

lib/inertia_rails/controller.rb

@@ -20,13 +20,6 @@ def inertia_share(**args, &block)
       end
     end
 
-    private
-
-    def inertia_location(url)
-      headers['X-Inertia-Location'] = url
-      head :conflict
-    end
-
     def redirect_to(options = {}, response_options = {})
       capture_inertia_errors(response_options)
       super(options, response_options)
@@ -41,6 +34,13 @@ def redirect_back(fallback_location:, allow_other_host: true, **options)
       )
     end
 
+    private
+
+    def inertia_location(url)
+      headers['X-Inertia-Location'] = url
+      head :conflict
+    end
+
     def capture_inertia_errors(options)
       if (inertia_errors = options.dig(:inertia, :errors))
         session[:inertia_errors] = inertia_errors

spec/dummy/app/controllers/inertia_responders_test_controller.rb

@@ -0,0 +1,13 @@
+require 'responders'
+
+class Thing
+end
+
+class InertiaRespondersTestController < ApplicationController
+  self.responder = ActionController::Responder
+  respond_to :html
+
+  def redirect_test
+    respond_with Thing.new, location: '/foo'
+  end
+end

spec/dummy/config/routes.rb

@@ -10,6 +10,7 @@
   get 'redirect_test' => 'inertia_test#redirect_test'
   get 'inertia_request_test' => 'inertia_test#inertia_request_test'
   get 'inertia_partial_request_test' => 'inertia_test#inertia_partial_request_test'
+  post 'redirect_with_responders' => 'inertia_responders_test#redirect_test'
   post 'redirect_test' => 'inertia_test#redirect_test'
   patch 'redirect_test' => 'inertia_test#redirect_test'
   put 'redirect_test' => 'inertia_test#redirect_test'

spec/inertia/request_spec.rb

@@ -89,4 +89,11 @@
       it { is_expected.to eq 'application/xml' }
     end
   end
+
+  describe 'it tests redirecting with responders gem' do
+    subject { response.status }
+    before { post redirect_with_responders_path }
+
+    it { is_expected.to eq 302 }
+  end
 end