fix: avoid leaking shared state across requests on error conditions (#83)

Author: ElMassimo

lib/inertia_rails/middleware.rb

@@ -7,6 +7,8 @@ def initialize(app)
     def call(env)
       InertiaRailsRequest.new(@app, env)
                          .response
+    ensure
+      ::InertiaRails.reset!
     end
 
     class InertiaRailsRequest
@@ -19,8 +21,6 @@ def response
         status, headers, body = @app.call(@env)
         request = ActionDispatch::Request.new(@env)
 
-        ::InertiaRails.reset!
-
         # Inertia errors are added to the session via redirect_to 
         request.session.delete(:inertia_errors) unless keep_inertia_errors?(status)
 

spec/dummy/app/controllers/inertia_multithreaded_share_controller.rb

@@ -6,4 +6,8 @@ def share_multithreaded
     sleep 1
     render inertia: 'ShareTestComponent'
   end
+
+  def share_multithreaded_error
+    raise Exception
+  end
 end

spec/dummy/config/routes.rb

@@ -17,6 +17,7 @@
   delete 'redirect_test' => 'inertia_test#redirect_test'
   get 'my_location' => 'inertia_test#my_location'
   get 'share_multithreaded' => 'inertia_multithreaded_share#share_multithreaded'
+  get 'share_multithreaded_error' => 'inertia_multithreaded_share#share_multithreaded_error'
   get 'redirect_with_inertia_errors' => 'inertia_test#redirect_with_inertia_errors'
   post 'redirect_with_inertia_errors' => 'inertia_test#redirect_with_inertia_errors'
   post 'redirect_back_with_inertia_errors' => 'inertia_test#redirect_back_with_inertia_errors'

spec/inertia/sharing_spec.rb

@@ -88,5 +88,15 @@
       thread1.join
       thread2.join
     end
+
+    it 'is expected not to leak shared data across requests' do
+      begin
+        get share_multithreaded_error_path, headers: {'X-Inertia' => true}
+      rescue Exception
+      end
+
+      expect(InertiaRails.shared_plain_data).to be_empty
+      expect(InertiaRails.shared_blocks).to be_empty
+    end
   end
 end