cleanup test files

Author: PedroAugustoRamalhoDuarte

spec/dummy/app/controllers/inertia_share_test_controller.rb

@@ -7,15 +7,11 @@ class InertiaShareTestController < ApplicationController
       number: number,
     }
   end
-  
+
   def share
     render inertia: 'ShareTestComponent'
   end
 
-  def error
-    raise RuntimeError
-  end
-
   private
 
   def number

spec/dummy/config/application.rb

@@ -32,15 +32,5 @@ class Application < Rails::Application
 
     # Required for Rails 5.0 and 5.1
     config.secret_key_base = SecureRandom.hex
-
-    config.exceptions_app = ->(env) do
-      Class.new(ActionController::Base) do
-        def show
-          render inertia: 'Error', props: {
-            status: request.path_info[1..-1].to_i
-          }
-        end
-      end.action(:show).call(env)
-    end
   end
 end

spec/dummy/config/routes.rb

@@ -5,7 +5,6 @@
   get 'view_data' => 'inertia_render_test#view_data'
   get 'component' => 'inertia_render_test#component'
   get 'share' => 'inertia_share_test#share'
-  get 'error' => 'inertia_share_test#error'
   get 'share_with_inherited' => 'inertia_child_share_test#share_with_inherited'
   get 'empty_test' => 'inertia_test#empty_test'
   get 'with_different_layout' => 'inertia_test#with_different_layout'

spec/inertia/sharing_spec.rb

@@ -77,58 +77,18 @@
 
         threads.each(&:join)
       end
+  end
 
-    describe 'deep or shallow merging shared data' do
-      context 'with default settings (shallow merge)' do
-        describe 'shallow merging by default' do
-          let(:props) { { nested: { assists: 200 } } }
-          before { get merge_shared_path, headers: {'X-Inertia' => true} }
-          it { is_expected.to eq props }
-        end
-
-        context 'with deep merge added to the renderer' do
-          let(:props) { { nested: { goals: 100, assists: 300 } } }
-          before { get deep_merge_shared_path, headers: {'X-Inertia' => true} }
-          it { is_expected.to eq props }
-        end
-      end
-
-      context 'with deep merge configured as the default' do
-        before {
-          InertiaRails.configure { |config| config.deep_merge_shared_data = true }
-        }
-        after {
-          InertiaRails.configure { |config| config.deep_merge_shared_data = false }
-        }
-        describe 'deep merging by default' do
-          let(:props) { { nested: { goals: 100, assists: 200 } } }
-          before { get merge_shared_path, headers: {'X-Inertia' => true} }
-          it { is_expected.to eq props }
-        end
-
-        describe 'overriding deep merge in a specific action' do
-          let(:props) { { nested: { assists: 200 } } }
-          before { get shallow_merge_shared_path, headers: {'X-Inertia' => true} }
-          it { is_expected.to eq props }
-        end
-      end
-
-      context 'merging with instance props' do
-        let(:props) { { nested: { points: 100, rebounds: 10 } } }
-        before { get merge_instance_props_path, headers: {'X-Inertia' => true} }
-        it { is_expected.to eq props }
-      end
-    end
-
+  context 'when raises an exception' do
     it 'is expected not to leak shared data across requests' do
       begin
         get share_multithreaded_error_path, headers: {'X-Inertia' => true}
       rescue Exception
       end
 
-      # TODO: How to test this? We really neeed?
-      # expect(InertiaRails.shared_plain_data).to be_empty
-      # expect(InertiaRails.shared_blocks).to be_empty
+      get share_path, headers: {'X-Inertia' => true}
+
+      is_expected.to eq({name: 'Brandon', sport: 'hockey', position: 'center', number: 29})
     end
   end
 
@@ -144,4 +104,46 @@
 
     it { is_expected.to eq props }
   end
+
+  describe 'deep or shallow merging shared data' do
+    context 'with default settings (shallow merge)' do
+      describe 'shallow merging by default' do
+        let(:props) { { nested: { assists: 200 } } }
+        before { get merge_shared_path, headers: {'X-Inertia' => true} }
+        it { is_expected.to eq props }
+      end
+
+      context 'with deep merge added to the renderer' do
+        let(:props) { { nested: { goals: 100, assists: 300 } } }
+        before { get deep_merge_shared_path, headers: {'X-Inertia' => true} }
+        it { is_expected.to eq props }
+      end
+    end
+
+    context 'with deep merge configured as the default' do
+      before {
+        InertiaRails.configure { |config| config.deep_merge_shared_data = true }
+      }
+      after {
+        InertiaRails.configure { |config| config.deep_merge_shared_data = false }
+      }
+      describe 'deep merging by default' do
+        let(:props) { { nested: { goals: 100, assists: 200 } } }
+        before { get merge_shared_path, headers: {'X-Inertia' => true} }
+        it { is_expected.to eq props }
+      end
+
+      describe 'overriding deep merge in a specific action' do
+        let(:props) { { nested: { assists: 200 } } }
+        before { get shallow_merge_shared_path, headers: {'X-Inertia' => true} }
+        it { is_expected.to eq props }
+      end
+    end
+
+    context 'merging with instance props' do
+      let(:props) { { nested: { points: 100, rebounds: 10 } } }
+      before { get merge_instance_props_path, headers: {'X-Inertia' => true} }
+      it { is_expected.to eq props }
+    end
+  end
 end