Merge pull request #62 from inertiajs/better-setup-specs-warning

Better setup specs warning

Author: bknoles

lib/inertia_rails/rspec.rb

@@ -35,6 +35,9 @@ module Helpers
       def inertia
         raise 'Inertia test helpers aren\'t set up! Make sure you add inertia: true to describe blocks using inertia tests.' unless inertia_tests_setup?
 
+        if @_inertia_render_wrapper.nil? && !::RSpec.configuration.inertia[:skip_missing_renderer_warnings]
+          warn 'WARNING: the test never created an Inertia renderer. Maybe the code wasn\'t able to reach a `render inertia:` call? If this was intended, or you don\'t want to see this message, set ::RSpec.configuration.inertia[:skip_missing_renderer_warnings] = true'
+        end
         @_inertia_render_wrapper
       end
 
@@ -49,14 +52,17 @@ def inertia_wrap_render(render)
       protected 
 
       def inertia_tests_setup?
-        @_inertia_render_wrapper.present?
+        ::RSpec.current_example.metadata.fetch(:inertia, false)
       end
     end
   end
 end
 
 RSpec.configure do |config|
   config.include ::InertiaRails::RSpec::Helpers
+  config.add_setting :inertia, default: {
+    skip_missing_renderer_warnings: false
+  }
 
   config.before(:each, inertia: true) do
     new_renderer = InertiaRails::Renderer.method(:new)

spec/dummy/app/controllers/inertia_test_controller.rb

@@ -23,6 +23,10 @@ def inertia_partial_request_test
     end
   end
 
+  def non_inertiafied
+    render plain: 'hey'
+  end
+
   # Calling it my_location to avoid this in Rails 5.0
   # https://github.com/rails/rails/issues/28033
   def my_location

spec/dummy/config/routes.rb

@@ -24,6 +24,7 @@
   get 'error_500' => 'inertia_test#error_500'
   get 'content_type_test' => 'inertia_test#content_type_test'
   get 'lazy_props' => 'inertia_render_test#lazy_props'
+  get 'non_inertiafied' => 'inertia_test#non_inertiafied'
 
   inertia 'inertia_route' => 'TestComponent'
 end

spec/inertia/rspec_helper_spec.rb

@@ -1,5 +1,21 @@
 require_relative '../../lib/inertia_rails/rspec'
 
+class FakeStdErr
+  attr_accessor :messages
+
+  def initialize
+    @messages = []
+  end
+
+  def write(msg)
+    @messages << msg
+  end
+
+  # Rails 5.0 + Ruby 2.6 require puts to be a public method
+  def puts(thing)
+  end
+end
+
 RSpec.describe InertiaRails::RSpec, type: :request do
   describe 'correctly set up inertia tests with inertia: true', inertia: true do
     context 'with props' do
@@ -54,4 +70,48 @@
       expect { expect_inertia }.to raise_error(/inertia: true/)
     end
   end
+
+  describe 'expecting inertia on a non inertia route', inertia: true do
+    before { get non_inertiafied_path }
+
+    it 'does not complain about test helpers' do
+      expect { expect_inertia }.not_to raise_error
+    end
+
+    # h/t for this technique:
+    # https://blog.arkency.com/testing-deprecations-warnings-with-rspec/
+    it 'warns that the renderer was never created' do
+      begin
+        original_stderr = $stderr
+        fake_std_err    = FakeStdErr.new
+        $stderr         = fake_std_err
+        expect_inertia
+        warn_message = 'WARNING: the test never created an Inertia renderer. Maybe the code wasn\'t able to reach a `render inertia:` call? If this was intended, or you don\'t want to see this message, set ::RSpec.configuration.inertia[:skip_missing_renderer_warnings] = true'
+        expect(fake_std_err.messages[0].chomp).to(eq(warn_message))
+      ensure
+        $std_err = original_stderr
+      end
+    end
+
+    context 'with the :skip_missing_renderer_warnings setting set to true' do
+      before {
+        @original = ::RSpec.configuration.inertia[:skip_missing_renderer_warnings]
+        ::RSpec.configuration.inertia[:skip_missing_renderer_warnings] = true
+      }
+      after {
+        ::RSpec.configuration.inertia[:skip_missing_renderer_warnings] = @original
+      }
+      it 'skips the warning' do
+        begin
+          original_stderr = $stderr
+          fake_std_err    = FakeStdErr.new
+          $stderr         = fake_std_err
+          expect_inertia
+          expect(fake_std_err.messages).to be_empty
+        ensure
+          $std_err = original_stderr
+        end
+      end
+    end
+  end
 end