Skip to content

Commit 1ab7800

Browse files
committed
[render-graph] Clean up build buffer method
1 parent 2734907 commit 1ab7800

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

src/vulkan-renderer/render_graph.cpp

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,28 +59,18 @@ PhysicalStage::~PhysicalStage() {}
5959
PhysicalGraphicsStage::~PhysicalGraphicsStage() {}
6060

6161
void RenderGraph::build_buffer(const BufferResource &buffer_resource, PhysicalBuffer &physical) const {
62-
// TODO: Don't always create mapped.
6362
const VmaAllocationCreateInfo alloc_ci{
6463
.flags = VMA_ALLOCATION_CREATE_MAPPED_BIT,
6564
.usage = VMA_MEMORY_USAGE_CPU_TO_GPU,
6665
};
6766

68-
auto buffer_ci = wrapper::make_info<VkBufferCreateInfo>({
67+
const auto buffer_ci = wrapper::make_info<VkBufferCreateInfo>({
6968
.size = buffer_resource.m_data_size,
69+
.usage = buffer_resource.m_usage == BufferUsage::INDEX_BUFFER ? VK_BUFFER_USAGE_INDEX_BUFFER_BIT
70+
: VK_BUFFER_USAGE_VERTEX_BUFFER_BIT,
7071
.sharingMode = VK_SHARING_MODE_EXCLUSIVE,
7172
});
7273

73-
switch (buffer_resource.m_usage) {
74-
case BufferUsage::INDEX_BUFFER:
75-
buffer_ci.usage = VK_BUFFER_USAGE_INDEX_BUFFER_BIT;
76-
break;
77-
case BufferUsage::VERTEX_BUFFER:
78-
buffer_ci.usage = VK_BUFFER_USAGE_VERTEX_BUFFER_BIT;
79-
break;
80-
default:
81-
assert(false);
82-
}
83-
8474
if (const auto result = vmaCreateBuffer(m_device.allocator(), &buffer_ci, &alloc_ci, &physical.m_buffer,
8575
&physical.m_allocation, &physical.m_alloc_info);
8676
result != VK_SUCCESS) {

0 commit comments

Comments
 (0)