Skip to content

Commit e140a4f

Browse files
committed
[application] Fix parameters
1 parent 7bd3245 commit e140a4f

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

include/inexor/vulkan-renderer/application.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ class Application : public VulkanRenderer {
6565

6666
/// @brief Call glfwSetCursorPosCallback.
6767
/// @param window The window that received the event.
68-
/// @param xpos The new x-coordinate, in screen coordinates, of the cursor.
69-
/// @param ypos The new y-coordinate, in screen coordinates, of the cursor.
70-
void cursor_position_callback(GLFWwindow *window, double xpos, double ypos);
68+
/// @param x_pos The new x-coordinate, in screen coordinates, of the cursor.
69+
/// @param y_pos The new y-coordinate, in screen coordinates, of the cursor.
70+
void cursor_position_callback(GLFWwindow *window, double x_pos, double y_pos);
7171

7272
/// @brief Call glfwSetMouseButtonCallback.
7373
/// @param window The window that received the event.
@@ -78,9 +78,9 @@ class Application : public VulkanRenderer {
7878

7979
/// @brief Call camera's process_mouse_scroll method.
8080
/// @param window The window that received the event.
81-
/// @param xoffset The change of x-offset of the mouse wheel.
82-
/// @param yoffset The change of y-offset of the mouse wheel.
83-
void mouse_scroll_callback(GLFWwindow *window, double xoffset, double yoffset);
81+
/// @param x_offset The change of x-offset of the mouse wheel.
82+
/// @param y_offset The change of y-offset of the mouse wheel.
83+
void mouse_scroll_callback(GLFWwindow *window, double x_offset, double y_offset);
8484

8585
void run();
8686
};

src/vulkan-renderer/application.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
namespace inexor::vulkan_renderer {
2020

21-
void Application::key_callback(GLFWwindow *, int key, int, int action, int) {
21+
void Application::key_callback(GLFWwindow * /*window*/, int key, int, int action, int /*mods*/) {
2222
switch (action) {
2323
case GLFW_PRESS:
2424
m_input_data->press_key(key);
@@ -31,11 +31,11 @@ void Application::key_callback(GLFWwindow *, int key, int, int action, int) {
3131
}
3232
}
3333

34-
void Application::cursor_position_callback(GLFWwindow *, double xpos, double ypos) {
35-
m_input_data->set_cursor_pos(xpos, ypos);
34+
void Application::cursor_position_callback(GLFWwindow * /*window*/, double x_pos, double y_pos) {
35+
m_input_data->set_cursor_pos(x_pos, y_pos);
3636
}
3737

38-
void Application::mouse_button_callback(GLFWwindow *, int button, int action, int) {
38+
void Application::mouse_button_callback(GLFWwindow * /*window*/, int button, int action, int /*mods*/) {
3939
switch (action) {
4040
case GLFW_PRESS:
4141
m_input_data->press_mouse_button(button);
@@ -48,8 +48,8 @@ void Application::mouse_button_callback(GLFWwindow *, int button, int action, in
4848
}
4949
}
5050

51-
void Application::mouse_scroll_callback(GLFWwindow *, double, double yoffset) {
52-
m_camera->change_zoom(static_cast<float>(yoffset));
51+
void Application::mouse_scroll_callback(GLFWwindow * /*window*/, double /*x_offset*/, double y_offset) {
52+
m_camera->change_zoom(static_cast<float>(y_offset));
5353
}
5454

5555
void Application::load_toml_configuration_file(const std::string &file_name) {

0 commit comments

Comments
 (0)