Fixed go-lint errors on secretId (needed secretID)

Author: infamousjoeg

pkg/conceal/keychain/keychain.go

@@ -11,12 +11,12 @@ import (
 )
 
 // SecretExists is a boolean function to verify a secret is present in keychain
-func SecretExists(secretId string) bool {
-	allSecretIds := ListSecrets()
+func SecretExists(secretID string) bool {
+	allsecretIDs := ListSecrets()
 
-	// Search all the available secretIds for this one
-	for _, id := range allSecretIds {
-		if id == secretId {
+	// Search all the available secretIDs for this one
+	for _, id := range allsecretIDs {
+		if id == secretID {
 			return true
 		}
 	}
@@ -40,21 +40,21 @@ func GetSecret() string {
 // with the label `summon`.
 func ListSecrets() []string {
 	// Note: OSX use the term "account" to refer to the secret id.
-	secretIds, err := keychain.GetGenericPasswordAccounts("summon")
+	secretIDs, err := keychain.GetGenericPasswordAccounts("summon")
 	if err != nil {
 		log.Fatalln(err)
 	}
 
-	return secretIds
+	return secretIDs
 }
 
 // AddSecret is a non-return function that adds the secret and secret value to
 // keychain.
-func AddSecret(secretId string) {
+func AddSecret(secretID string) {
 	// Add new generic password item to keychain
 	secret := []byte(GetSecret())
 	item := keychain.NewGenericPassword(
-		"summon", secretId, "summon", secret, "",
+		"summon", secretID, "summon", secret, "",
 	)
 	item.SetSynchronizable(keychain.SynchronizableNo)
 	item.SetAccessible(keychain.AccessibleAfterFirstUnlock)
@@ -66,7 +66,7 @@ func AddSecret(secretId string) {
 		log.Fatalf(
 			"An error occurred trying to add a secret to keychain.\n"+
 				"Secret '%s' already exists. Exiting...\n",
-			secretId,
+			secretID,
 		)
 	}
 
@@ -80,25 +80,25 @@ func AddSecret(secretId string) {
 	}
 
 	// Verify the secret was set in keychain successfully
-	if !SecretExists(secretId) {
+	if !SecretExists(secretID) {
 		log.Fatalf("Secret %s not found in keychain. Exiting...\n", secret)
 	}
 
-	fmt.Printf("Added %s successfully to keychain.\n", secretId)
+	fmt.Printf("Added %s successfully to keychain.\n", secretID)
 	return
 }
 
 // DeleteSecret is a non-return function that removes the secret from keychain
-func DeleteSecret(secretId string) {
-	err := keychain.DeleteGenericPasswordItem("summon", secretId)
+func DeleteSecret(secretID string) {
+	err := keychain.DeleteGenericPasswordItem("summon", secretID)
 	if err != nil {
 		log.Fatalf(
 			"An error occurred trying to remove secret from "+
 				"keychain.\n  Secret '%s' not found in keychain. Exiting...\n",
-			secretId,
+			secretID,
 		)
 	}
 
-	fmt.Printf("Removed %s successfully from keychain.\n", secretId)
+	fmt.Printf("Removed %s successfully from keychain.\n", secretID)
 	return
 }