fix: Make VersionParser throw the correct exception upon invalid version (#58)

Currently it throws an `InvalidArgumentException` but the abstract test
framework package provides an `InvalidVersion` exception, which is what
is documented for `TestFrameworkAdapter::getVersion()`.

Author: theofidry

src/CodeceptionAdapter.php

@@ -43,11 +43,11 @@
 use function explode;
 use function implode;
 use Infection\AbstractTestFramework\Coverage\TestLocation;
+use Infection\AbstractTestFramework\InvalidVersion;
 use Infection\AbstractTestFramework\MemoryUsageAware;
 use Infection\AbstractTestFramework\TestFrameworkAdapter;
 use Infection\StreamWrapper\IncludeInterceptor;
 use Infection\TestFramework\Codeception\Coverage\JUnitTestCaseSorter;
-use InvalidArgumentException;
 use function is_string;
 use const LOCK_EX;
 use Phar;
@@ -237,7 +237,7 @@ public function getVersion(): string
 
         try {
             $version = $this->versionParser->parse($process->getOutput());
-        } catch (InvalidArgumentException $e) {
+        } catch (InvalidVersion) {
             $version = 'unknown';
         }
 

src/VersionParser.php

@@ -35,8 +35,9 @@
 
 namespace Infection\TestFramework\Codeception;
 
-use InvalidArgumentException;
+use Infection\AbstractTestFramework\InvalidVersion;
 use function preg_match;
+use function sprintf;
 
 /**
  * @internal
@@ -45,15 +46,34 @@ class VersionParser
 {
     private const VERSION_REGEX = '/(?<version>[0-9]+\.[0-9]+\.?[0-9]*)(?<prerelease>-[0-9a-zA-Z.]+)?(?<build>\+[0-9a-zA-Z.]+)?/';
 
+    /**
+     * @throws InvalidVersion
+     */
     public function parse(string $content): string
     {
         $matches = [];
         $matched = preg_match(self::VERSION_REGEX, $content, $matches) > 0;
 
         if (!$matched) {
-            throw new InvalidArgumentException('Parameter does not contain a valid SemVer (sub)string.');
+            throw self::createInvalidVersion(
+                CodeceptionAdapter::NAME,
+                $content,
+            );
         }
 
         return $matches[0];
     }
+
+    private static function createInvalidVersion(
+        string $testFrameworkName,
+        string $version,
+    ): InvalidVersion {
+        return new InvalidVersion(
+            sprintf(
+                'Could not recognise the test framework version for %s for the value "%s".',
+                $testFrameworkName,
+                $version,
+            ),
+        );
+    }
 }

tests/phpunit/Adapter/VersionParserTest.php

@@ -35,8 +35,8 @@
 
 namespace Infection\Tests\TestFramework\Codeception\Adapter;
 
+use Infection\AbstractTestFramework\InvalidVersion;
 use Infection\TestFramework\Codeception\VersionParser;
-use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
 
 final class VersionParserTest extends TestCase
@@ -60,16 +60,13 @@ public function test_it_parses_version_from_string(string $content, string $expe
 
     public function test_it_throws_exception_when_content_has_no_version_substring(): void
     {
-        try {
-            $this->versionParser->parse('abc');
-
-            $this->fail();
-        } catch (InvalidArgumentException $exception) {
-            $this->assertSame(
-                'Parameter does not contain a valid SemVer (sub)string.',
-                $exception->getMessage(),
-            );
-        }
+        $this->expectExceptionObject(
+            new InvalidVersion(
+                'Could not recognise the test framework version for codeception for the value "abc".',
+            ),
+        );
+
+        $this->versionParser->parse('abc');
     }
 
     /**