refactor: Inject the test framework name from the factory instead of the adapter (#51)

See the rationale in
infection/phpspec-adapter#89.

Author: theofidry

src/CodeceptionAdapter.php

@@ -79,6 +79,7 @@ final class CodeceptionAdapter implements MemoryUsageAware, TestFrameworkAdapter
     private ?string $cachedVersion = null;
 
     public function __construct(
+        private readonly string $name,
         private string $testFrameworkExecutable,
         private CommandLineBuilder $commandLineBuilder,
         private VersionParser $versionParser,
@@ -137,7 +138,7 @@ public function getMemoryUsed(string $output): float
 
     public function getName(): string
     {
-        return self::NAME;
+        return $this->name;
     }
 
     public function getInitialTestRunCommandLine(string $extraOptions, array $phpExtraArgs, bool $skipCoverage): array

src/CodeceptionAdapterFactory.php

@@ -46,6 +46,8 @@
 
 final class CodeceptionAdapterFactory implements TestFrameworkAdapterFactory
 {
+    private const NAME = 'Codeception';
+
     private const COVERAGE_DIR = 'coverage-xml';
 
     /**
@@ -62,9 +64,10 @@ public static function create(
         bool $skipCoverage,
     ): TestFrameworkAdapter {
         return new CodeceptionAdapter(
+            self::NAME,
             $testFrameworkExecutable,
             new CommandLineBuilder(),
-            new VersionParser(),
+            new VersionParser(self::NAME),
             new JUnitTestCaseSorter(),
             new Filesystem(),
             Path::makeRelative($jUnitFilePath, $tmpDir),
@@ -80,7 +83,7 @@ public static function create(
 
     public static function getAdapterName(): string
     {
-        return CodeceptionAdapter::NAME;
+        return 'codeception';
     }
 
     public static function getExecutableName(): string

src/VersionParser.php

@@ -46,6 +46,11 @@ class VersionParser
 {
     private const VERSION_REGEX = '/(?<version>[0-9]+\.[0-9]+\.?[0-9]*)(?<prerelease>-[0-9a-zA-Z.]+)?(?<build>\+[0-9a-zA-Z.]+)?/';
 
+    public function __construct(
+        private readonly string $name,
+    ) {
+    }
+
     /**
      * @throws InvalidVersion
      */
@@ -56,7 +61,7 @@ public function parse(string $content): string
 
         if (!$matched) {
             throw self::createInvalidVersion(
-                CodeceptionAdapter::NAME,
+                $this->name,
                 $content,
             );
         }

tests/phpunit/Adapter/CodeceptionAdapterTest.php

@@ -434,9 +434,10 @@ public static function phpCoverageOptionProvider(): iterable
     private function createAdapter(?array $config = null, ?string $version = 'unknown'): CodeceptionAdapter
     {
         $adapter = new CodeceptionAdapter(
+            'codeception',
             '/path/to/codeception',
             new CommandLineBuilder(),
-            new VersionParser(),
+            new VersionParser('Codeception'),
             new JUnitTestCaseSorter(),
             new Filesystem(),
             'path/to/junit',

tests/phpunit/Adapter/VersionParserTest.php

@@ -45,7 +45,7 @@ final class VersionParserTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->versionParser = new VersionParser();
+        $this->versionParser = new VersionParser('TestCodeception');
     }
 
     /**
@@ -62,7 +62,7 @@ public function test_it_throws_exception_when_content_has_no_version_substring()
     {
         $this->expectExceptionObject(
             new InvalidVersion(
-                'Could not recognise the test framework version for codeception for the value "abc".',
+                'Could not recognise the test framework version for TestCodeception for the value "abc".',
             ),
         );