Skip to content

Commit a1441de

Browse files
committed
Python 3.8 support
1 parent 3eb27c1 commit a1441de

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

.github/workflows/unittests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
max-parallel: 1
1818
matrix:
19-
python-version: ["3.9", "3.12"]
19+
python-version: ["3.8", "3.9", "3.12"]
2020
environment: ["cloud"]
2121

2222
uses: ./.github/workflows/action-test.yml

nocodb/Column.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from __future__ import annotations
12
class Column:
23
def __init__(self, **kwargs) -> None:
34
self.title = kwargs["title"]

nocodb/Record.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from __future__ import annotations
12
from typing import TYPE_CHECKING
23

34
from nocodb.Column import Column

nocodb/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from __future__ import annotations
12
import requests
23
from urllib.parse import urlsplit, urljoin
34
import logging
@@ -84,7 +85,7 @@ def get_base_by_title(self, title: str) -> Base:
8485

8586
def create_base(self, title:str, **kwargs) -> Base:
8687
kwargs["title"] = title
87-
88+
8889
r = self.call_noco(path="meta/bases",
8990
method="POST",
9091
json=kwargs)
@@ -106,4 +107,3 @@ def is_cloud(self) -> bool:
106107
return self.__app_info["isCloud"]
107108
else:
108109
return self.get_app_info()["isCloud"]
109-

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "py-nocodb"
33
version = "0.0.1"
44
description = "Python client for NocoDB API v2"
55
readme = "README.md"
6-
requires-python = ">=3.9"
6+
requires-python = ">=3.8"
77
license = { file = "LICENSE" }
88
authors = [{ name = "infeeeee", email = "[email protected]" }]
99
maintainers = [{ name = "infeeeee", email = "[email protected]" }]

tests/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM python:3.9-slim-bullseye
1+
FROM python:3.8-slim-bullseye
22

33
WORKDIR /root/nocodb
44

@@ -8,4 +8,4 @@ RUN pip install --no-cache-dir .
88

99
CMD python -m unittest discover -v -s ./tests -p "test_*.py"
1010

11-
# docker run --rm -it $(docker build -q -f tests/Dockerfile .)
11+
# docker run --rm -it $(docker build -q -f tests/Dockerfile .)

0 commit comments

Comments
 (0)