Skip to content

Commit 19ca9c7

Browse files
committed
ci: integration test fixes
1 parent d728e8a commit 19ca9c7

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,16 +252,18 @@ jobs:
252252
run: |
253253
docker compose up -d ledger
254254
echo "Waiting for Ledger to be ready..."
255+
# Check from host side (port 50052 is mapped to container's 50051)
256+
# Distroless container doesn't have nc/shell utilities
255257
for i in {1..30}; do
256-
if docker compose exec -T ledger nc -z localhost 50051 2>/dev/null; then
258+
if nc -z localhost 50052 2>/dev/null; then
257259
echo "Ledger is ready!"
258260
break
259261
fi
260262
echo "Attempt $i/30: Ledger not ready yet..."
261263
sleep 2
262264
done
263265
# Final check
264-
docker compose exec -T ledger nc -z localhost 50051 || (docker compose logs ledger && exit 1)
266+
nc -z localhost 50052 || (docker compose logs ledger && exit 1)
265267
266268
- name: Run Ledger integration tests
267269
env:

docker/ledger-integration-tests/docker-compose.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,9 @@ services:
2929
RUST_LOG: "info,inferadb_ledger_server=debug"
3030
tmpfs:
3131
- /var/lib/ledger:uid=65532,gid=65532
32-
healthcheck:
33-
test: ["CMD-SHELL", "nc -z localhost 50051 || exit 1"]
34-
interval: 2s
35-
timeout: 5s
36-
retries: 30
37-
start_period: 10s
32+
# Note: Healthcheck removed because distroless image has no shell/utilities.
33+
# CI uses host-side port checking instead. For local development with
34+
# docker-compose, the test-runner will retry connections automatically.
3835
deploy:
3936
resources:
4037
limits:
@@ -53,8 +50,7 @@ services:
5350
networks:
5451
- control-ledger-test-network
5552
depends_on:
56-
ledger:
57-
condition: service_healthy
53+
- ledger
5854
environment:
5955
LEDGER_ENDPOINT: "http://ledger:50051"
6056
LEDGER_NAMESPACE_ID: "1"

0 commit comments

Comments
 (0)