improve: code cleanup

Author: evansims

.github/workflows/ci.yml

@@ -399,15 +399,20 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
-      - name: Install Rust toolchain
+      - name: Install Rust toolchain (stable + nightly for udeps)
         uses: dtolnay/rust-toolchain@e97e2d8cc328f1b50210efc529dca0028893a2d9 # v1
         with:
           toolchain: stable
 
+      - name: Install Rust nightly toolchain (for cargo-udeps)
+        uses: dtolnay/rust-toolchain@0b1efabc08b657293548b77fb76cc02d26091c7e # master
+        with:
+          toolchain: nightly
+
       - name: Install development tools via Mise
         uses: step-security/mise-action@2fa1b2b4fa1577588d8ac75f4dfa0f67c266d2a0 # v3.4.1
         with:
-          install_args: cargo:cargo-outdated
+          install_args: protobuf cargo:cargo-outdated cargo:cargo-udeps
           cache: true
 
       - name: Cache Rust dependencies
@@ -416,6 +421,9 @@ jobs:
       - name: Check outdated dependencies
         run: cargo outdated --exit-code 1 || echo "Some dependencies are outdated"
 
+      - name: Check for unused dependencies
+        run: cargo +nightly udeps --workspace --all-targets || echo "Some dependencies may be unused"
+
       - name: Check for duplicate dependencies
         run: cargo tree --duplicates
 

Cargo.toml

@@ -32,7 +32,7 @@ bon = "3.8"
 
 # Error handling
 anyhow = "1.0"
-thiserror = "2.0"
+snafu = "0.8"
 
 # System
 num_cpus = "1.16"
@@ -143,6 +143,16 @@ rustls = { version = "0.23", default-features = false, features = [
   "aws_lc_rs",
 ] }
 
+[workspace.lints.rust]
+unsafe_code = "deny"
+
+[workspace.lints.clippy]
+unwrap_used = "warn"
+expect_used = "warn"
+panic = "warn"
+todo = "warn"
+unimplemented = "warn"
+
 [profile.release]
 codegen-units = 1
 lto = "thin"

crates/inferadb-control-api/Cargo.toml

@@ -28,12 +28,10 @@ chrono = { workspace = true }
 ed25519-dalek = { workspace = true }
 jsonwebtoken = { workspace = true }
 metrics-exporter-prometheus = { workspace = true }
-pem = "3.0"
+pem = { workspace = true }
 rand = { workspace = true }
-reqwest = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-serde_yaml = { workspace = true }
 time = { workspace = true }
 tokio = { workspace = true }
 tower = { workspace = true }
@@ -46,5 +44,8 @@ inferadb-control-test-fixtures = { path = "../inferadb-control-test-fixtures" }
 inferadb-engine-auth = { path = "../../../engine/crates/inferadb-engine-auth" }
 rand_core = { version = "0.6", features = ["getrandom"] }
 
+[lints]
+workspace = true
+
 [features]
 default = []

crates/inferadb-control-api/src/handlers/audit_logs.rs

@@ -133,6 +133,7 @@ pub async fn list_audit_logs(
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use std::sync::Arc;
 

crates/inferadb-control-api/src/handlers/auth.rs

@@ -529,6 +529,7 @@ pub async fn confirm_password_reset(
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use tower::ServiceExt;
 

crates/inferadb-control-api/src/handlers/cli_auth.rs

@@ -157,6 +157,7 @@ fn generate_secure_code(length: usize) -> Vec<u8> {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use std::sync::Arc;
 

crates/inferadb-control-api/src/handlers/emails.rs

@@ -287,6 +287,7 @@ pub async fn delete_email(
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use std::sync::Arc;
 

crates/inferadb-control-api/src/handlers/health.rs

@@ -112,17 +112,10 @@ pub async fn healthz_handler(State(state): State<AppState>) -> impl IntoResponse
     // Get instance details from state
     let instance_id = state.worker_id;
     let start_time = state.start_time;
-    let is_leader = state
-        .leader
-        .as_ref()
-        .map(|l| {
-            let leader_check = l.clone();
-            // Use tokio::task::block_in_place to avoid blocking the runtime
-            tokio::task::block_in_place(|| {
-                tokio::runtime::Handle::current().block_on(leader_check.is_leader())
-            })
-        })
-        .unwrap_or(false);
+    let is_leader = match &state.leader {
+        Some(leader) => leader.is_leader().await,
+        None => false,
+    };
 
     // Calculate uptime
     let uptime_seconds = SystemTime::now().duration_since(start_time).unwrap_or_default().as_secs();
@@ -145,6 +138,7 @@ pub async fn healthz_handler(State(state): State<AppState>) -> impl IntoResponse
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use std::sync::Arc;
 

crates/inferadb-control-api/src/handlers/metrics.rs

@@ -14,6 +14,8 @@ static METRICS_HANDLE: OnceLock<PrometheusHandle> = OnceLock::new();
 /// It sets up the Prometheus exporter that will collect and expose metrics.
 pub fn init_exporter() {
     METRICS_HANDLE.get_or_init(|| {
+        // Metrics recorder installation failure is unrecoverable at startup
+        #[allow(clippy::expect_used)]
         let handle = PrometheusBuilder::new()
             .install_recorder()
             .expect("Failed to install Prometheus recorder");
@@ -45,6 +47,7 @@ pub async fn metrics_handler() -> Response {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used, clippy::expect_used)]
 mod tests {
     use super::*;
 

crates/inferadb-control-api/src/handlers/mod.rs

@@ -13,6 +13,8 @@ pub mod tokens;
 pub mod users;
 pub mod vaults;
 
-pub use auth::*;
+pub use auth::{
+    AppState, confirm_password_reset, login, logout, register, request_password_reset, verify_email,
+};
 pub use health::{healthz_handler, livez_handler, readyz_handler, startupz_handler};
 pub use metrics::{init_exporter, metrics_handler};