improve: fdb → ledger

Author: evansims

config.yaml

@@ -1,5 +1,11 @@
 # InferaDB Control Configuration - Development Defaults
 # Good defaults for local development and testing
+#
+# STORAGE BEHAVIOR:
+# - Default is "ledger" (production-ready, cryptographically verifiable)
+# - In development environment with no Ledger config, auto-falls back to "memory"
+# - Use --dev-mode flag to force memory storage regardless of config
+# - Set storage: "memory" explicitly for persistent development mode
 
 control:
   frontend:
@@ -10,10 +16,12 @@ control:
     grpc: "127.0.0.1:9091"
     mesh: "0.0.0.0:9092"
 
-  # Storage backend: "memory" (default) or "ledger"
+  # Storage backend: "ledger" (default, production) or "memory" (development)
+  # In development mode without Ledger config, automatically uses memory.
+  # Uncomment to explicitly use memory storage:
   # storage: "memory"
 
-  # Ledger storage configuration (requires --features ledger)
+  # Ledger storage configuration (required in production)
   # Provides cryptographically verifiable storage using InferaDB Ledger
   # ledger:
   #   endpoint: "http://localhost:50051"

crates/inferadb-control-config/src/lib.rs

@@ -319,7 +319,7 @@ fn default_logging() -> String {
 }
 
 fn default_storage() -> String {
-    "memory".to_string()
+    "ledger".to_string()
 }
 
 fn default_email_port() -> u16 {
@@ -614,6 +614,39 @@ impl ControlConfig {
 
         Ok(())
     }
+
+    /// Apply environment-aware defaults for storage backend.
+    ///
+    /// In development environment, if Ledger is the default but no Ledger configuration
+    /// is provided, automatically fall back to memory storage for convenience.
+    /// This allows `cargo run` to "just work" without requiring Ledger setup.
+    ///
+    /// In production or when Ledger configuration is explicitly provided,
+    /// no changes are made and validation will enforce proper configuration.
+    ///
+    /// # Arguments
+    ///
+    /// * `environment` - The environment name (e.g., "development", "staging", "production")
+    pub fn apply_environment_defaults(&mut self, environment: &str) {
+        // Only apply in development environment
+        if environment != "development" {
+            return;
+        }
+
+        // If storage is ledger (the default) and no ledger config is provided,
+        // fall back to memory for developer convenience
+        if self.storage == "ledger"
+            && self.ledger.endpoint.is_none()
+            && self.ledger.client_id.is_none()
+            && self.ledger.namespace_id.is_none()
+        {
+            tracing::info!(
+                "Development mode: No Ledger configuration provided, using memory storage. \
+                 Set storage='memory' explicitly or provide ledger config to suppress this message."
+            );
+            self.storage = "memory".to_string();
+        }
+    }
 }
 
 #[cfg(test)]
@@ -625,7 +658,7 @@ mod tests {
         assert_eq!(default_http(), "127.0.0.1:9090");
         assert_eq!(default_grpc(), "127.0.0.1:9091");
         assert_eq!(default_mesh(), "0.0.0.0:9092");
-        assert_eq!(default_storage(), "memory");
+        assert_eq!(default_storage(), "ledger"); // Ledger is now the default
         assert_eq!(default_webauthn_party(), "localhost");
         assert_eq!(default_webauthn_origin(), "http://localhost:3000");
     }

crates/inferadb-control-storage/src/optimization.rs

@@ -223,11 +223,8 @@ impl<B: StorageBackend + Clone> BatchWriter<B> {
             return Vec::new();
         }
 
-        let max_bytes = if self.config.enabled {
-            self.config.max_batch_bytes
-        } else {
-            TRANSACTION_SIZE_LIMIT
-        };
+        let max_bytes =
+            if self.config.enabled { self.config.max_batch_bytes } else { TRANSACTION_SIZE_LIMIT };
 
         let max_ops = if self.config.enabled { self.config.max_batch_size } else { usize::MAX };
 

crates/inferadb-control-storage/tests/ledger_integration_tests.rs

@@ -3,14 +3,13 @@
 //! These tests require a running Ledger server. They are skipped unless the
 //! `RUN_LEDGER_INTEGRATION_TESTS` environment variable is set.
 //!
-//! Run with: cargo test --test ledger_integration_tests --features ledger
+//! Run with: cargo test --test ledger_integration_tests
 //!
 //! Or using Docker Compose:
 //! ```bash
 //! cd docker/ledger-integration-tests && ./run-tests.sh
 //! ```
 
-#![cfg(feature = "ledger")]
 #![allow(clippy::unwrap_used, clippy::expect_used)]
 
 use std::{
@@ -51,7 +50,7 @@ async fn create_ledger_backend() -> LedgerBackend {
     let vault_id = unique_vault_id();
     let config = LedgerBackendConfig::builder()
         .with_endpoint(ledger_endpoint())
-        .with_client_id(&format!("control-test-{}", vault_id))
+        .with_client_id(format!("control-test-{}", vault_id))
         .with_namespace_id(ledger_namespace_id())
         .with_vault_id(vault_id)
         .build()
@@ -240,15 +239,13 @@ async fn test_ledger_concurrent_writes() {
         return;
     }
 
-    let backend = create_ledger_backend().await;
-
-    // Spawn concurrent writers
+    // Spawn concurrent writers (each gets its own backend with unique vault)
     let mut handles = Vec::new();
     for i in 0..10 {
         let vault_id = unique_vault_id();
         let config = LedgerBackendConfig::builder()
             .with_endpoint(ledger_endpoint())
-            .with_client_id(&format!("concurrent-test-{}", vault_id))
+            .with_client_id(format!("concurrent-test-{}", vault_id))
             .with_namespace_id(ledger_namespace_id())
             .with_vault_id(vault_id)
             .build()
@@ -284,15 +281,15 @@ async fn test_ledger_vault_isolation() {
 
     let config_a = LedgerBackendConfig::builder()
         .with_endpoint(ledger_endpoint())
-        .with_client_id(&format!("vault-a-{}", vault_a))
+        .with_client_id(format!("vault-a-{}", vault_a))
         .with_namespace_id(ledger_namespace_id())
         .with_vault_id(vault_a)
         .build()
         .unwrap();
 
     let config_b = LedgerBackendConfig::builder()
         .with_endpoint(ledger_endpoint())
-        .with_client_id(&format!("vault-b-{}", vault_b))
+        .with_client_id(format!("vault-b-{}", vault_b))
         .with_namespace_id(ledger_namespace_id())
         .with_vault_id(vault_b)
         .build()

crates/inferadb-control/src/main.rs

@@ -27,6 +27,12 @@ struct Args {
     /// Environment (development, staging, production)
     #[arg(short, long, env = "ENVIRONMENT", default_value = "development")]
     environment: String,
+
+    /// Force development mode with in-memory storage.
+    /// Use this flag for local development and testing without Ledger.
+    /// In production, Ledger storage is the default and required.
+    #[arg(long)]
+    dev_mode: bool,
 }
 
 #[tokio::main]
@@ -46,7 +52,17 @@ async fn main() -> Result<()> {
     }
 
     // Load configuration
-    let config = ControlConfig::load(&args.config)?;
+    let mut config = ControlConfig::load(&args.config)?;
+
+    // Apply environment-aware defaults (in development, auto-fallback to memory if no Ledger config)
+    config.apply_environment_defaults(&args.environment);
+
+    // Handle --dev-mode flag: force memory storage for development/testing
+    if args.dev_mode {
+        tracing::info!("Development mode enabled via --dev-mode flag: using memory storage");
+        config.storage = "memory".to_string();
+    }
+
     config.validate()?;
 
     // Initialize structured logging with environment-appropriate format