Skills create separate browser sessions instead of sharing sessions

[edenreich]

Bug Description

The Playwright skills (navigate_to_url and take_screenshot) each create their own browser sessions instead of sharing a single session. This causes screenshots to be blank because:

1. navigate_to_url creates session A and navigates to a URL
2. take_screenshot creates session B (fresh/blank) and takes a screenshot of an empty page

Evidence

From agent logs:

• Navigation: sessionID: session_1758373522286453631
• Screenshot: sessionID: session_1758373522844540590

Expected Behavior

Skills should share the same browser session so that:

• Navigation happens in session A
• Screenshot captures the content from the same session A

Current Implementation Issue

Both skills have getOrCreateSession() methods that always create new sessions:

take_screenshot.go:238-246:

func (s *TakeScreenshotSkill) getOrCreateSession(ctx context.Context) (*playwright.BrowserSession, error) {
    config := playwright.DefaultBrowserConfig()
    session, err := s.playwright.LaunchBrowser(ctx, config)
    // Always creates new session
}

Solution

Implement session sharing in the Playwright service so skills can reuse existing sessions instead of always creating new ones.

Impact

• Screenshots are blank/empty
• No access logs showing agent reaching websites
• Poor user experience with browser automation workflows

[edenreich]

@claude Can you work on fixing this bug?

[claude]

Claude finished @edenreich's task —— View job • claude/issue-22-20250920-1312 • Create PR ➔

---

Fixing Playwright Session Sharing Bug ✅ COMPLETED

I've successfully fixed the bug where Playwright skills create separate browser sessions instead of sharing sessions, which was causing blank screenshots.

Todo List:

• Analyze current codebase structure and Playwright implementation
• Examine the session creation logic in skills
• Design session sharing mechanism
• Implement session sharing in Playwright service
• Update skills to use shared sessions
• Run linting and tests
• Commit changes and create PR

Summary of Changes:

1. Added GetOrCreateDefaultSession() to BrowserAutomation interface - New method for session sharing
2. Implemented thread-safe session sharing logic in Playwright service - Uses "default" session ID with proper concurrency handling
3. Updated ALL 7 skills to use shared session instead of always creating new ones:
   • navigate_to_url.go, take_screenshot.go, click_element.go
   • extract_data.go, execute_script.go, fill_form.go, wait_for_condition.go
4. Updated mocks and tests - Added GetOrCreateDefaultSession to mock interface and updated all skill tests

Results:

✅ Root cause resolved: Skills now share the same browser session
✅ All 66 tests pass - No regressions introduced
✅ Backwards compatible - Existing session management still works
✅ Thread-safe implementation - Proper mutex handling for concurrent access

Commit: 9e3a8eff

The fix has been committed to branch claude/issue-22-20250920-1312.