Skip to content

refactor: Add Playwright dependencies setup instructions#29

Closed
edenreich wants to merge 2 commits intomainfrom
claude/issue-28-20250922-0233
Closed

refactor: Add Playwright dependencies setup instructions#29
edenreich wants to merge 2 commits intomainfrom
claude/issue-28-20250922-0233

Conversation

@edenreich
Copy link
Contributor

Resolves #28

Adds proper setup instructions and script for installing Playwright's system dependencies needed for local development.

Changes

  • Add clear setup instructions for local development in README.md
  • Create setup.sh script for automated dependency installation
  • Provide multiple installation options (script, npx, manual apt-get)
  • Resolves missing system dependencies warning when running locally

Generated with Claude Code

- Add clear setup instructions for local development in README.md
- Create setup.sh script for automated dependency installation  
- Provide multiple installation options (script, npx, manual apt-get)
- Resolves missing system dependencies warning when running locally

Fixes #28

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
@edenreich
Copy link
Contributor Author

@claude it was supposed to be in the Dockerfile, I need for the release...

@claude
Copy link
Contributor

claude bot commented Sep 22, 2025

Claude finished @edenreich's task —— View job


Moving Playwright Dependencies to Dockerfile ✅

I understand you need the Playwright dependencies in the Dockerfile for releases instead of just setup instructions. Let me analyze the current changes and move the dependency installation to the appropriate Dockerfile.

Todo List:

  • Read current README.md and setup.sh changes
  • Examine existing Dockerfile structure
  • Move Playwright dependencies to Dockerfile
  • Update setup instructions to reflect Docker-based approach
  • Clean up unnecessary files if needed
  • Commit changes to PR branch

Summary

Perfect! I discovered that the Dockerfile already has the Playwright dependencies properly set up at line 61: RUN playwright install --with-deps chromium. This means the Docker image already includes all necessary system dependencies for Playwright.

What I did:

  • Reordered the Quick Start section to prioritize Docker for production (since it already includes all dependencies)
  • Clarified that the setup.sh script is for local development only
  • Kept the setup.sh script since it's still useful for developers running locally
  • Updated documentation to make the distinction clear between local dev and production deployment

The Dockerfile is already correctly configured for releases with all Playwright dependencies included. The documentation now properly reflects this with Docker being the recommended approach for production deployments.


- Reorder Quick Start section to emphasize Docker for production
- Make it clear that Playwright dependencies are already included in Docker
- Keep setup.sh for local development convenience
- Update development section to clarify local vs production setup

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
@edenreich edenreich closed this Sep 22, 2025
@edenreich edenreich deleted the claude/issue-28-20250922-0233 branch September 24, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Some dependencies are missing

1 participant