Resolve all clippy warnings and replace fixed sleep with bounded poll

Eliminate field_reassign_with_default in client config tests using struct
update syntax. Replace unnecessary_get_then_check in registry with
contains_key. Reorder signing.rs to place feature-gated items before test
module. Replace unconditional 5s sleep in integration test with bounded
poll loop that retries at 250ms intervals with a 10s deadline.

Author: HudsonGraeme

crates/btlightning/src/client.rs

@@ -872,9 +872,8 @@ impl LightningClient {
         for addr_key in state.registry.connection_addrs() {
             let status = match state.registry.get_connection(addr_key) {
                 Some(conn) => {
-                    let close_reason = conn.close_reason();
-                    if close_reason.is_some() {
-                        format!("closed({:?})", close_reason.unwrap())
+                    if let Some(reason) = conn.close_reason() {
+                        format!("closed({:?})", reason)
                     } else {
                         "active".to_string()
                     }
@@ -1755,8 +1754,10 @@ mod tests {
 
     #[test]
     fn with_config_rejects_frame_payload_below_minimum() {
-        let mut cfg = LightningClientConfig::default();
-        cfg.max_frame_payload_bytes = 512;
+        let cfg = LightningClientConfig {
+            max_frame_payload_bytes: 512,
+            ..LightningClientConfig::default()
+        };
         assert!(LightningClient::with_config("hk".into(), cfg).is_err());
     }
 
@@ -1767,23 +1768,30 @@ mod tests {
             Ok(v) => v,
             Err(_) => return,
         };
-        let mut cfg = LightningClientConfig::default();
-        cfg.max_frame_payload_bytes = val;
-        cfg.max_stream_payload_bytes = val;
+        let cfg = LightningClientConfig {
+            max_frame_payload_bytes: val,
+            max_stream_payload_bytes: val,
+            ..LightningClientConfig::default()
+        };
         assert!(LightningClient::with_config("hk".into(), cfg).is_err());
     }
 
     #[test]
     fn with_config_rejects_stream_below_frame() {
-        let mut cfg = LightningClientConfig::default();
-        cfg.max_stream_payload_bytes = cfg.max_frame_payload_bytes - 1;
+        let base = LightningClientConfig::default();
+        let cfg = LightningClientConfig {
+            max_stream_payload_bytes: base.max_frame_payload_bytes - 1,
+            ..base
+        };
         assert!(LightningClient::with_config("hk".into(), cfg).is_err());
     }
 
     #[test]
     fn with_config_rejects_zero_stream_chunk_timeout() {
-        let mut cfg = LightningClientConfig::default();
-        cfg.stream_chunk_timeout = Some(Duration::ZERO);
+        let cfg = LightningClientConfig {
+            stream_chunk_timeout: Some(Duration::ZERO),
+            ..LightningClientConfig::default()
+        };
         assert!(LightningClient::with_config("hk".into(), cfg).is_err());
     }
 

crates/btlightning/src/registry.rs

@@ -329,10 +329,10 @@ mod tests {
         reg.register(QuicAxonInfo::new("hk1".into(), "1.2.3.4".into(), 8080, 4));
         let rs = reg.reconnect_state_or_insert(old_addr.clone());
         rs.attempts = 3;
-        assert!(reg.reconnect_states.get(&old_addr).is_some());
+        assert!(reg.reconnect_states.contains_key(&old_addr));
 
         reg.register(QuicAxonInfo::new("hk1".into(), "5.6.7.8".into(), 9090, 4));
-        assert!(reg.reconnect_states.get(&old_addr).is_none());
+        assert!(!reg.reconnect_states.contains_key(&old_addr));
         reg.assert_invariants();
     }
 

crates/btlightning/src/signing.rs

@@ -86,6 +86,47 @@ impl<F: Fn(&[u8]) -> Result<Vec<u8>> + Send + Sync> Signer for CallbackSigner<F>
     }
 }
 
+/// [`Signer`] backed by a `btwallet` keypair loaded from the Bittensor wallet directory.
+///
+/// Requires the `btwallet` feature.
+#[cfg(feature = "btwallet")]
+pub struct BtWalletSigner {
+    keypair: bittensor_wallet::Keypair,
+}
+
+#[cfg(feature = "btwallet")]
+impl BtWalletSigner {
+    /// Wraps an existing `btwallet::Keypair`.
+    pub fn new(keypair: bittensor_wallet::Keypair) -> Self {
+        Self { keypair }
+    }
+
+    /// Loads the hotkey keypair from `~/<path>/<name>/hotkeys/<hotkey_name>`.
+    pub fn from_wallet(name: &str, path: &str, hotkey_name: &str) -> Result<Self> {
+        let wallet = bittensor_wallet::Wallet::new(
+            Some(name.to_string()),
+            Some(path.to_string()),
+            Some(hotkey_name.to_string()),
+            None,
+        );
+        let keypair = wallet
+            .get_hotkey(Some(hotkey_name.to_string()))
+            .map_err(|e| {
+                LightningError::Config(format!("failed to load hotkey from wallet: {}", e))
+            })?;
+        Ok(Self { keypair })
+    }
+}
+
+#[cfg(feature = "btwallet")]
+impl Signer for BtWalletSigner {
+    fn sign(&self, message: &[u8]) -> Result<Vec<u8>> {
+        self.keypair
+            .sign(message.to_vec())
+            .map_err(LightningError::Signing)
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -157,44 +198,3 @@ mod tests {
         assert!(err.to_string().contains("network down"));
     }
 }
-
-/// [`Signer`] backed by a `btwallet` keypair loaded from the Bittensor wallet directory.
-///
-/// Requires the `btwallet` feature.
-#[cfg(feature = "btwallet")]
-pub struct BtWalletSigner {
-    keypair: bittensor_wallet::Keypair,
-}
-
-#[cfg(feature = "btwallet")]
-impl BtWalletSigner {
-    /// Wraps an existing `btwallet::Keypair`.
-    pub fn new(keypair: bittensor_wallet::Keypair) -> Self {
-        Self { keypair }
-    }
-
-    /// Loads the hotkey keypair from `~/<path>/<name>/hotkeys/<hotkey_name>`.
-    pub fn from_wallet(name: &str, path: &str, hotkey_name: &str) -> Result<Self> {
-        let wallet = bittensor_wallet::Wallet::new(
-            Some(name.to_string()),
-            Some(path.to_string()),
-            Some(hotkey_name.to_string()),
-            None,
-        );
-        let keypair = wallet
-            .get_hotkey(Some(hotkey_name.to_string()))
-            .map_err(|e| {
-                LightningError::Config(format!("failed to load hotkey from wallet: {}", e))
-            })?;
-        Ok(Self { keypair })
-    }
-}
-
-#[cfg(feature = "btwallet")]
-impl Signer for BtWalletSigner {
-    fn sign(&self, message: &[u8]) -> Result<Vec<u8>> {
-        self.keypair
-            .sign(message.to_vec())
-            .map_err(LightningError::Signing)
-    }
-}

crates/btlightning/tests/integration.rs

@@ -2010,13 +2010,22 @@ async fn query_works_via_update_miner_registry_after_delay() {
         .await
         .unwrap();
 
-    tokio::time::sleep(Duration::from_secs(5)).await;
-
-    let resp = client
-        .query_axon_with_timeout(axon.clone(), build_request("echo"), Duration::from_secs(5))
-        .await
-        .unwrap();
-    assert!(resp.success);
+    let deadline = tokio::time::Instant::now() + Duration::from_secs(10);
+    loop {
+        match client
+            .query_axon_with_timeout(axon.clone(), build_request("echo"), Duration::from_secs(2))
+            .await
+        {
+            Ok(resp) => {
+                assert!(resp.success);
+                break;
+            }
+            Err(_) if tokio::time::Instant::now() < deadline => {
+                tokio::time::sleep(Duration::from_millis(250)).await;
+            }
+            Err(e) => panic!("query did not succeed within deadline: {e}"),
+        }
+    }
 
     client.close_all_connections().await.unwrap();
     env.shutdown().await;