Issues with potion system

[davidshapovalov]

Hello, and thank you for your work.

Ever since the bug that caused crashes after entering the game a second time, my friends and I have been trying to include this wonderful mod in our modpack - for almost half a year now.
Then, the potion update came out, which unfortunately brought a number of compatibility issues. These include:

• Incompatibility of potions with other mods (which, as I understand, has already been fixed),
• Incompatibility with Combat Nouveau (specifically, there's no way to disable drinking speed and item stacking changes),
  When disabling all potion changes, the Combat Nouveau changes also stop working.
• No compatibility with Eat Animations

I understand that implementing proper support might take a while and that you may not currently have the time for it. But could you please at least add an option to fully disable all potion-related changes in the config?

I mean not to revert to vanilla values, but literally remove all potion changes.

This would allow us - and many others, I'm sure - to use the mod in our packs without conflicts while you work on deeper fixes or integrations. Even partial toggle options for individual features would help a lot.

We really love your mod and have been eager to include it for months, but right now the potion system causes too many issues.
Thank you for considering this!

[Lyof429]

Hello! First of all I want to say I appreciate a lot the positivity and kindness of your message ^^

Truly sorry for all the messing up my mod causes ^^'. 1.7.3 released a few days ago should fix these issues, it added config options to disable most if not all potion shenanigans:

"potion": {
    "stack_size": 8,
    // Value to multiply all potions effects length by.
    //    For example, if this is 2, then all effects gained *from potions* will last twice as long
    //    This has no effect on potions whose effects were overridden by datapack
    "duration_multiplier": 1.5,
    // How many ticks should drinking a potion take. 20t = 1s
    "drinking_time": 20,
    // How many ticks of cooldown potions get after being drank or thrown
    "cooldown": 200,
    
    // Should potions have the ability to have different textures depending on their content.
    //   Setting this to false will disable texture variants for long/strong potions, as well as per potion ones
    "custom_potion_textures": true,
    // Should potions' properties be editable by datapack. Keep in mind that to fully disable modifications to potions,
    //   You also need to set stack_size to 1, duration_multiplier to 1, drinking_time to 0 and cooldown to 0
    "custom_potion_data": true
}

Setting stack_size back to 1, duration_multiplier to 1, drinking_time to 0 (aka: cancel changes), cooldown to 0, and both booleans at the end to false should prevent any custom logic to be applied.
If anything stays edited, please let me know, it shouldn't happen.

That being said, in what way exactly does Eating Animations lack compatiblity? I can look into it if the above doesn't fix issues.

[Vladyslav1728]

If your new texture is applied to the potion, the potion drinking animation does not work (Eat Animation)

[davidshapovalov]

Thank you very much for your response! I think your explanation cleared up all the questions we had. We just assumed that all potion changes would be completely removed, but it seems we can work with the configs.

The issue, as mentioned earlier by another user, is that when your mod changes the potion textures, it prevents us from re-skinning or using the Eating Animation mod properly.

Also, I wanted to ask about crashes involving EMF/ETF mods. It seems like the developers of those mods are not planning to fix these crashes. Would you be able to look into fixing compatibility or crashes with EMF/ETF?

[Lyof429]

Okie, great!
Eating Animation compat is surely doable by resource pack then, will read their docs and try to figure it out

They are not planning to fix them? Damn ;-;
Is that like an official statement or just "they didn't do anything yet" though?
Because I can probably hack my way through mixins but I'm unsure how stable it would be, plus it's much better if they actually fix this for any similar mod .-.
(The issue is on their side, maybe from me doing something wrong but it's their code so editing it is a bit tough)