fix approval check

Author: trevor-coleman

src/jobs/build_docs_with_approval.yml

@@ -42,13 +42,13 @@ parameters:
     default: "source"
     description: "The directory where the clone of the source repo has been cloned."
   manual_approval_granted:
-    type: boolean
-    default: false
+    type: string
+    default: ""
     description: "This job will run code from forked repos. It should always be reviewed before this job is run."
 steps:
   - validate_param:
-      param_name: "manual_approval_granted"
-      param_value: true
+      param_name: 'manual_approval_granted'
+      param_value: "<<parameters.manual_approval_granted>>"
   - validate_params:
       git_email: <<parameters.git_email>>
       git_username: <<parameters.git_username>>

src/jobs/manual_approval.yml

@@ -5,7 +5,7 @@ ValidateParam() {
     echo "Error: Missing parameter"
     exit 1
   fi
-  echo "Param is set correctly"
+  echo "Param is set"
 }
 
 ORB_TEST_ENV="bats-core"