Merge pull request #34 from infinum/update-standards

Update standards

Author: Ivan Ružević

Infinum/ruleset.xml

@@ -88,6 +88,22 @@
     <!-- Disallow spacing inside arrays. -->
     <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
 
+    <!-- Private methods MUST not be prefixed with an underscore -->
+    <rule ref="Squiz.NamingConventions.ValidFunctionName.PrivateNoUnderscore">
+        <severity>0</severity>
+    </rule>
+    <rule ref="PSR2.Methods.MethodDeclaration.Underscore">
+        <type>error</type>
+    </rule>
+
+    <!-- Private properties MUST not be prefixed with an underscore -->
+    <rule ref="Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore">
+        <severity>0</severity>
+    </rule>
+    <rule ref="PSR2.Classes.PropertyDeclaration.Underscore">
+        <type>error</type>
+    </rule>
+
     <!-- Ensure proper object instantiation. -->
     <rule ref="WordPress.Classes.ClassInstantiation"/>
 

tests/code-example-6.php

@@ -0,0 +1,30 @@
+<?php
+
+/**
+ * Test
+ *
+ * @package Test
+ */
+
+ namespace A;
+
+/**
+ * Class
+ */
+class ClassName
+{
+	/**
+	 * Service array
+	 *
+	 * @var array Services
+	 */
+	private $service = [];
+
+	/**
+	 * Method name
+	 */
+	private function doSomethingPrivate()
+	{
+		return '';
+	}
+}