Skip to content

Commit 1eab3b3

Browse files
committed
fix: messed up rebase
1 parent 7fabb3b commit 1eab3b3

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

host/src/lib.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use ::http::HeaderName;
88
use arrow::datatypes::DataType;
99
use datafusion_common::{DataFusionError, Result as DataFusionResult, config::ConfigOptions};
1010
use datafusion_expr::{
11-
ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature,
11+
ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignature,
1212
async_udf::{AsyncScalarUDF, AsyncScalarUDFImpl},
1313
};
1414
use tokio::{runtime::Handle, sync::Mutex};
@@ -538,11 +538,7 @@ impl AsyncScalarUDFImpl for WasmScalarUdf {
538538
let columnar_value: ColumnarValue = return_type.try_into()?;
539539
match columnar_value {
540540
ColumnarValue::Array(v) => Ok(v),
541-
<<<<<<< HEAD
542541
ColumnarValue::Scalar(v) => v.to_array_of_size(args.number_rows as usize),
543-
=======
544-
ColumnarValue::Scalar(v) => v.to_array_of_size(1),
545-
>>>>>>> c980278 (feat: use AsyncScalarUDFImpl instead of ScalarUDFImpl)
546542
}
547543
}
548544
}

query/src/lib.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22
#![allow(unused_crate_dependencies)]
33

44
use std::collections::HashMap;
5-
use std::sync::Arc;
65

76
use datafusion::execution::TaskContext;
87
use datafusion_common::{DataFusionError, Result as DataFusionResult};
9-
use datafusion_expr::async_udf::AsyncScalarUDFImpl;
108
use datafusion_sql::parser::{DFParserBuilder, Statement};
119
use sqlparser::ast::{CreateFunctionBody, Expr, Statement as SqlStatement, Value};
1210
use sqlparser::dialect::dialect_from_str;
@@ -33,7 +31,7 @@ pub struct Lang<'a> {
3331
#[derive(Debug)]
3432
pub struct ParsedQuery {
3533
/// Extracted UDFs from the query
36-
pub udfs: Vec<Arc<dyn AsyncScalarUDFImpl>>,
34+
pub udfs: Vec<WasmScalarUdf>,
3735
/// SQL query string with UDF definitions removed
3836
pub sql: String,
3937
}

query/tests/integration.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ use datafusion_udf_wasm_query::{
2020
use tokio::runtime::Handle;
2121

2222
mod integration_tests;
23-
use datafusion_expr::async_udf::AsyncScalarUDF;
2423

2524
use crate::integration_tests::python::test_utils::python_component;
2625

0 commit comments

Comments
 (0)