Merge pull request #158 from influxdata/crepererum/more-lints

chore: extend lints

Author: crepererum

Cargo.toml

@@ -55,14 +55,22 @@ wit-bindgen = { version = "0.47", default-features = false, features = [
 ] }
 
 [workspace.lints.clippy]
-allow_attributes = "warn"
+allow_attributes = "deny"
 clone_on_ref_ptr = "deny"
+comparison_chain = "deny"
 dbg_macro = "deny"
 explicit_iter_loop = "deny"
 future_not_send = "deny"
 missing_docs_in_private_items = "deny"
+range_minus_one = "deny"
+range_plus_one = "deny"
+semicolon_if_nothing_returned = "deny"
 todo = "deny"
 undocumented_unsafe_blocks = "deny"
+unnecessary_semicolon = "deny"
+unnecessary_wraps = "deny"
+unused_async = "deny"
+unused_self = "deny"
 use_self = "deny"
 
 [workspace.lints.rust]

guests/rust/examples/add_one.rs

@@ -102,6 +102,7 @@ fn root() -> Option<Vec<u8>> {
 /// Returns our one example UDF.
 ///
 /// The passed `source` is ignored.
+#[expect(clippy::unnecessary_wraps, reason = "public API through export! macro")]
 fn udfs(_source: String) -> DataFusionResult<Vec<Arc<dyn ScalarUDFImpl>>> {
     Ok(vec![Arc::new(AddOne::default())])
 }

query/src/lib.rs

@@ -67,7 +67,7 @@ impl<'a> UdfQueryParser<'a> {
         io_rt: Handle,
         task_ctx: &TaskContext,
     ) -> DataFusionResult<ParsedQuery> {
-        let (code, sql) = self.parse_inner(udf_query, task_ctx)?;
+        let (code, sql) = Self::parse_inner(udf_query, task_ctx)?;
 
         let mut udfs = vec![];
         for (lang, blocks) in code {
@@ -92,7 +92,6 @@ impl<'a> UdfQueryParser<'a> {
     /// Parse the combined query to extract the chosen UDF language, UDF
     /// definitions, and SQL statements.
     fn parse_inner(
-        &self,
         query: &str,
         task_ctx: &TaskContext,
     ) -> DataFusionResult<(HashMap<String, Vec<String>>, String)> {