feat: single threaded flavors

Author: Sl1mb0

host/tests/integration_tests/python/argument_forms.rs

@@ -15,7 +15,7 @@ use datafusion_expr::{
 
 use crate::integration_tests::python::test_utils::python_scalar_udf;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_positional_or_keyword() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -55,7 +55,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_positional_or_keyword_default() {
     const CODE: &str = "
 def foo(x: int = 1) -> int:
@@ -77,7 +77,7 @@ def foo(x: int = 1) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_positional_only() {
     const CODE: &str = "
 def foo(x: int, /) -> int:
@@ -117,7 +117,7 @@ def foo(x: int, /) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_positional_only_default() {
     const CODE: &str = "
 def foo(x: int = 1, /) -> int:
@@ -139,7 +139,7 @@ def foo(x: int = 1, /) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_positional_or_keyword_and_positional_only() {
     const CODE: &str = "
 def foo(x: int, /, y: int) -> int:
@@ -182,7 +182,7 @@ def foo(x: int, /, y: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_var_positional() {
     const CODE: &str = "
 def foo(*x: int) -> int:
@@ -204,7 +204,7 @@ def foo(*x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_keyword_only() {
     const CODE: &str = "
 def foo(*, x: int) -> int:
@@ -226,7 +226,7 @@ def foo(*, x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_var_keyword() {
     const CODE: &str = "
 def foo(**x: int) -> int:

host/tests/integration_tests/python/examples.rs

@@ -13,7 +13,7 @@ use datafusion_expr::{
 
 use crate::integration_tests::python::test_utils::python_scalar_udf;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_add_one() {
     const CODE: &str = "
 def add_one(x: int) -> int:
@@ -32,10 +32,9 @@ def add_one(x: int) -> int:
         udf.return_type(&[DataType::Int64]).unwrap(),
         DataType::Int64,
     );
-    assert_eq!(
-        udf.return_type(&[]).unwrap_err().to_string(),
-        "Error during planning: `add_one` expects 1 parameters but got 0",
-    );
+    // Signature is exact, so it would have been cached;
+    // thus - no error even with a wrong type of argument.
+    assert_eq!(udf.return_type(&[]).unwrap(), DataType::Int64,);
 
     // call with array
     let array = udf

host/tests/integration_tests/python/inspection/errors.rs

@@ -1,7 +1,7 @@
 use crate::integration_tests::python::test_utils::python_scalar_udfs;
 use datafusion_common::DataFusionError;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_invalid_syntax() {
     const CODE: &str = ")";
 
@@ -18,7 +18,7 @@ async fn test_invalid_syntax() {
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_missing_return_type() {
     const CODE: &str = "
 def add_one(x: int):
@@ -43,7 +43,7 @@ def add_one(x: int):
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_missing_arg_type() {
     const CODE: &str = "
 def add_one(x) -> int:
@@ -68,7 +68,7 @@ def add_one(x) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_union_type_2() {
     const CODE: &str = "
 def add_one(x: int | str) -> int:
@@ -93,7 +93,7 @@ def add_one(x: int | str) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_union_type_2_and_none() {
     const CODE: &str = "
 def add_one(x: int | str | None) -> int:
@@ -118,7 +118,7 @@ def add_one(x: int | str | None) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_union_type_2_identical() {
     const CODE: &str = "
 def add_one(x: int | str | int) -> int:
@@ -143,7 +143,7 @@ def add_one(x: int | str | int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_union_type_2_identical_and_none() {
     const CODE: &str = "
 def add_one(x: int | None | str | int) -> int:
@@ -168,7 +168,7 @@ def add_one(x: int | None | str | int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_union_type_3() {
     const CODE: &str = "
 def add_one(x: int | str | float) -> int:
@@ -193,7 +193,7 @@ def add_one(x: int | str | float) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_type_annotation_is_not_a_type() {
     const CODE: &str = "
 def add_one(x: 1337) -> int:
@@ -218,7 +218,7 @@ def add_one(x: 1337) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_unsupported_type() {
     const CODE: &str = "
 def add_one(x: list[int]) -> int:
@@ -243,7 +243,7 @@ def add_one(x: list[int]) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_custom_type() {
     const CODE: &str = "
 class C:
@@ -271,7 +271,7 @@ def add_one(x: C) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_exception() {
     const CODE: &str = "
 raise Exception('foo')

host/tests/integration_tests/python/inspection/filter.rs

@@ -1,7 +1,7 @@
 use crate::integration_tests::python::test_utils::python_scalar_udfs;
 use datafusion_expr::ScalarUDFImpl;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_underscore() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -14,7 +14,7 @@ def _bar(x: int) -> int:
     assert_eq!(found_udfs(CODE).await, ["foo".to_owned()]);
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_non_callalbes() {
     const CODE: &str = "
 variable = 1
@@ -26,7 +26,7 @@ def foo(x: int) -> int:
     assert_eq!(found_udfs(CODE).await, ["foo".to_owned()]);
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_imports() {
     const CODE: &str = "
 from sys import exit
@@ -38,7 +38,7 @@ def foo(x: int) -> int:
     assert_eq!(found_udfs(CODE).await, ["foo".to_owned()]);
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_classes() {
     const CODE: &str = "
 class C:

host/tests/integration_tests/python/runtime/dependencies.rs

@@ -9,7 +9,7 @@ use datafusion_expr::{ColumnarValue, ScalarFunctionArgs, async_udf::AsyncScalarU
 
 use crate::integration_tests::python::test_utils::python_scalar_udf;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn call_other_function() {
     const CODE: &str = "
 def _sub1(x: int) -> int:
@@ -45,7 +45,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn functools_cache() {
     const CODE: &str = "
 from functools import cache

host/tests/integration_tests/python/runtime/errors.rs

@@ -12,7 +12,7 @@ use datafusion_expr::{
 
 use crate::integration_tests::python::test_utils::python_scalar_udf;
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_return_type_param_mismatch() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -21,23 +21,15 @@ def foo(x: int) -> int:
 
     let udf = python_scalar_udf(CODE).await.unwrap();
 
+    // Signature is exact, so it would have been cached;
+    // thus - no error even with a wrong type of argument.
     insta::assert_snapshot!(
-        udf.return_type(&[]).unwrap_err(),
-        @"Error during planning: `foo` expects 1 parameters but got 0",
-    );
-
-    insta::assert_snapshot!(
-        udf.return_type(&[DataType::Int64, DataType::Int64]).unwrap_err(),
-        @"Error during planning: `foo` expects 1 parameters but got 2",
-    );
-
-    insta::assert_snapshot!(
-        udf.return_type(&[DataType::Float64]).unwrap_err(),
-        @"Error during planning: argument 1 of `foo` should be Int64, got Float64",
+        udf.return_type(&[]).unwrap(),
+        @"Int64",
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_invoke_args_mismatch() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -133,7 +125,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_invoke_arg_fields_mismatch() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -188,7 +180,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_invoke_return_field_mismatch() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -226,7 +218,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_should_not_return_none() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -239,7 +231,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_exception_direct() {
     const CODE: &str = "
 def foo(x: int) -> int:
@@ -258,7 +250,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_exception_indirect() {
     const CODE: &str = "
 def _inner1() -> None:
@@ -308,7 +300,7 @@ def foo(x: int) -> int:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_stack_overflow() {
     // borrowed from https://wiki.python.org/moin/CrashingPython
     const CODE: &str = "

host/tests/integration_tests/python/runtime/fs.rs

@@ -11,7 +11,7 @@ use tokio::runtime::Handle;
 
 use crate::integration_tests::python::test_utils::{python_component, python_scalar_udf};
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_listdir() {
     const CODE: &str = r#"
 import os
@@ -110,7 +110,7 @@ def listdir(cwd: str | None, dir: str) -> str:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_read() {
     const CODE: &str = r#"
 def read(path: str) -> str:
@@ -181,7 +181,7 @@ if __name__ == '__main__':
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_write() {
     const CODE: &str = r#"
 def write(path: str) -> str:
@@ -236,7 +236,7 @@ def write(path: str) -> str:
     );
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_limit_inodes() {
     let component = python_component().await;
 
@@ -258,7 +258,7 @@ async fn test_limit_inodes() {
         @"IO error: inodes limit reached: limit<=42 current==42 requested+=1");
 }
 
-#[tokio::test(flavor = "multi_thread")]
+#[tokio::test]
 async fn test_limit_bytes() {
     let component = python_component().await;