fix: Remove the stacker dependency (#5229)

* fix: Remove the stacker dependency

This seems to cause issues with cross-compilation downstream.

* chore: make generate

* chore: make staticcheck

Author: Markus Westerlind

ast/testcase/testcase.go

@@ -2,7 +2,7 @@ package testcase
 
 import (
 	"context"
-	"io/ioutil"
+	"io"
 	"path/filepath"
 	"strings"
 
@@ -149,7 +149,7 @@ func extendTest(file *ast.File, extends string, modules TestModules) ([]*ast.Imp
 	if err != nil {
 		return nil, nil, nil, err
 	}
-	contents, err := ioutil.ReadAll(f)
+	contents, err := io.ReadAll(f)
 	_ = f.Close()
 	if err != nil {
 		return nil, nil, nil, err

cmd/flux/cmd/test.go

@@ -10,7 +10,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"regexp"
@@ -571,7 +570,7 @@ func gatherFromTarArchive(filename string) ([]testFile, fs, testcase.TestModules
 			continue
 		}
 
-		source, err := ioutil.ReadAll(archive)
+		source, err := io.ReadAll(archive)
 		if err != nil {
 			return nil, nil, nil, err
 		}
@@ -830,7 +829,7 @@ func readTestRoot(f io.Reader, err error) (string, []string, error) {
 	if rc, ok := f.(io.ReadCloser); ok {
 		defer func() { _ = rc.Close() }()
 	}
-	data, err := ioutil.ReadAll(f)
+	data, err := io.ReadAll(f)
 	if err != nil {
 		return "", nil, err
 	}

cmd/flux/fmt.go

@@ -3,7 +3,6 @@ package main
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 
@@ -52,7 +51,7 @@ func formatFile(cmd *cobra.Command, args []string) error {
 }
 
 func format(script string) (bool, error) {
-	fromFile, err := ioutil.ReadFile(script)
+	fromFile, err := os.ReadFile(script)
 	if err != nil {
 		return false, err
 	}
@@ -86,7 +85,7 @@ func format(script string) (bool, error) {
 }
 
 func updateScript(fname string, script string) error {
-	err := ioutil.WriteFile(fname, []byte(script), 0644)
+	err := os.WriteFile(fname, []byte(script), 0644)
 	if err != nil {
 		return err
 	}

cmd/flux/main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
 	"os"
 
 	fluxcmd "github.com/influxdata/flux/cmd/flux/cmd"
@@ -35,7 +34,7 @@ func runE(cmd *cobra.Command, args []string) error {
 		if flags.ExecScript {
 			script = args[0]
 		} else {
-			content, err := ioutil.ReadFile(args[0])
+			content, err := os.ReadFile(args[0])
 			if err != nil {
 				return err
 			}

csv/result_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"errors"
-	"io/ioutil"
+	"io"
 	"regexp"
 	"strings"
 	"testing"
@@ -2485,7 +2485,7 @@ func TestMultiResultDecoder(t *testing.T) {
 		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			decoder := csv.NewMultiResultDecoder(tc.config)
-			results, err := decoder.Decode(ioutil.NopCloser(bytes.NewReader(tc.encoded)))
+			results, err := decoder.Decode(io.NopCloser(bytes.NewReader(tc.encoded)))
 			if err != nil {
 				t.Fatal(err)
 			}

dependencies/dependenciestest/dependencies.go

@@ -2,7 +2,7 @@ package dependenciestest
 
 import (
 	"context"
-	"io/ioutil"
+	"io"
 	"net/http"
 
 	"github.com/influxdata/flux"
@@ -31,7 +31,7 @@ func defaultTestFunction(req *http.Request) *http.Response {
 		Status:     "Body generated by test client",
 
 		// Send response to be tested
-		Body: ioutil.NopCloser(body),
+		Body: io.NopCloser(body),
 
 		// Must be set to non-nil value or it panics
 		Header: make(http.Header),

dependencies/filesystem/ioutil.go

@@ -2,7 +2,7 @@ package filesystem
 
 import (
 	"context"
-	"io/ioutil"
+	"io"
 	"os"
 )
 
@@ -18,7 +18,7 @@ func ReadFile(ctx context.Context, filename string) ([]byte, error) {
 		return nil, err
 	}
 	defer func() { _ = f.Close() }()
-	return ioutil.ReadAll(f)
+	return io.ReadAll(f)
 }
 
 // OpenFile will open the file from the service.

dependencies/filesystem/systemfs_test.go

@@ -3,7 +3,6 @@ package filesystem_test
 import (
 	"context"
 	"io"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"testing"
@@ -12,7 +11,7 @@ import (
 )
 
 func TestSystemFS_Open(t *testing.T) {
-	tmpfile, err := ioutil.TempFile("", "flux-systemfs-test")
+	tmpfile, err := os.CreateTemp("", "flux-systemfs-test")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -33,7 +32,7 @@ func TestSystemFS_Open(t *testing.T) {
 	}
 	defer func() { _ = f.Close() }()
 
-	data, err := ioutil.ReadAll(f)
+	data, err := io.ReadAll(f)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -48,7 +47,7 @@ func TestSystemFS_Open(t *testing.T) {
 }
 
 func TestSystemFS_Stat(t *testing.T) {
-	tmpfile, err := ioutil.TempFile("", "flux-systemfs-test")
+	tmpfile, err := os.CreateTemp("", "flux-systemfs-test")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -71,7 +70,7 @@ func TestSystemFS_Stat(t *testing.T) {
 }
 
 func TestSystemFS_ReadFile(t *testing.T) {
-	tmpfile, err := ioutil.TempFile("", "flux-systemfs-test")
+	tmpfile, err := os.CreateTemp("", "flux-systemfs-test")
 	if err != nil {
 		t.Fatal(err)
 	}

dependencies/http/http_test.go

@@ -2,7 +2,7 @@ package http
 
 import (
 	"bytes"
-	"io/ioutil"
+	"io"
 	"log"
 	"net"
 	"net/http"
@@ -75,7 +75,7 @@ func TestIpValidation(t *testing.T) {
 	}
 
 	// Mock a dns server.
-	dnsLogger := log.New(ioutil.Discard, "mockdns server: ", log.LstdFlags)
+	dnsLogger := log.New(io.Discard, "mockdns server: ", log.LstdFlags)
 	srv, _ := mockdns.NewServerWithLogger(bad, dnsLogger, false)
 	defer srv.Close()
 
@@ -125,7 +125,7 @@ func TestInvalidRedirects(t *testing.T) {
 	}
 
 	// Mock a dns server.
-	dnsLogger := log.New(ioutil.Discard, "mockdns server: ", log.LstdFlags)
+	dnsLogger := log.New(io.Discard, "mockdns server: ", log.LstdFlags)
 	srv, _ := mockdns.NewServerWithLogger(bad, dnsLogger, false)
 	defer srv.Close()
 

dependencies/influxdb/http.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"encoding/json"
 	"io"
-	"io/ioutil"
 	stdhttp "net/http"
 	"net/url"
 	"sort"
@@ -149,7 +148,7 @@ func (h *HttpClient) Query(ctx context.Context, f func(table flux.Table) error,
 	if err != nil {
 		return err
 	} else if resp.StatusCode != 200 {
-		data, err := ioutil.ReadAll(resp.Body)
+		data, err := io.ReadAll(resp.Body)
 		if err != nil {
 			return errors.Newf(codes.Invalid, "error when reading response body: %s", err)
 		}