Skip to content

Commit e7b7c8e

Browse files
authored
fix: Fixes running tests in PHP 8 environments (#139)
1 parent 84ed54c commit e7b7c8e

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ FROM php:7.2-cli AS dev
22

33
COPY --from=composer /usr/bin/composer /usr/bin/
44

5-
RUN yes | pecl install xdebug \
5+
RUN yes | pecl install xdebug-2.9.8 \
66
&& echo "zend_extension=$(find /usr/local/lib/php/extensions/ -name xdebug.so)" > /usr/local/etc/php/conf.d/xdebug.ini \
77
&& echo "xdebug.remote_enable=on" >> /usr/local/etc/php/conf.d/xdebug.ini \
88
&& echo "xdebug.remote_autostart=on" >> /usr/local/etc/php/conf.d/xdebug.ini

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dshell: ## Start Docker Shell for Local Development
88
@docker-compose run --entrypoint=bash --rm php
99

1010
deps: ## Installs the project dependencies
11-
@composer install
11+
@docker-compose run php composer install
1212

1313
test: start-server ## Perform unit tests
1414
@docker-compose run php composer run test

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,8 +631,15 @@ For more info see Redirect Plugin docs - [allow_redirects](https://docs.php-http
631631

632632
## Local tests
633633

634+
Run once to install dependencies:
635+
636+
```shell script
637+
make deps
638+
```
639+
640+
Run unit & intergration tests:
641+
634642
```shell script
635-
# run unit & integration tests
636643
make test
637644
```
638645

0 commit comments

Comments
 (0)