chore: Update rust toolchain to 1.87.0 (#26456)

Changes were due to a number of clippy improvements

Author: stuartcarnie

influxdb3_catalog/src/catalog.rs

@@ -437,7 +437,7 @@ impl Catalog {
     // NOTE: this could be id-based in future
     pub fn active_triggers(&self) -> Vec<(Arc<str>, Arc<str>)> {
         let inner = self.inner.read();
-        let result = inner
+        inner
             .databases
             .resource_iter()
             .flat_map(|db| {
@@ -451,8 +451,7 @@ impl Catalog {
                         }
                     })
             })
-            .collect();
-        result
+            .collect()
     }
 
     pub fn get_tokens(&self) -> Vec<Arc<TokenInfo>> {

influxdb3_load_generator/src/main.rs

@@ -120,7 +120,6 @@ fn get_runtime(num_threads: Option<usize>) -> Result<Runtime, std::io::Error> {
     // requires a running tokio runtime and is initialised after this function.
 
     use tokio::runtime::Builder;
-    let kind = std::io::ErrorKind::Other;
     match num_threads {
         None => Runtime::new(),
         Some(num_threads) => {
@@ -131,7 +130,7 @@ fn get_runtime(num_threads: Option<usize>) -> Result<Runtime, std::io::Error> {
                 0 => {
                     let msg =
                         format!("Invalid num-threads: '{num_threads}' must be greater than zero");
-                    Err(std::io::Error::new(kind, msg))
+                    Err(std::io::Error::other(msg))
                 }
                 1 => Builder::new_current_thread().enable_all().build(),
                 _ => Builder::new_multi_thread()

influxdb3_processing_engine/src/plugins.rs

@@ -718,7 +718,7 @@ mod python_plugin {
     }
 
     enum Schedule {
-        Cron(OwnedScheduleIterator<Utc>),
+        Cron(Box<OwnedScheduleIterator<Utc>>),
         Every(Duration),
     }
 
@@ -767,7 +767,7 @@ mod python_plugin {
             }
         }
         fn new_cron(cron_schedule: CronSchedule, time_provider: Arc<dyn TimeProvider>) -> Self {
-            let mut schedule = cron_schedule.after_owned(time_provider.now().date_time());
+            let mut schedule = Box::new(cron_schedule.after_owned(time_provider.now().date_time()));
             let next_trigger_time = schedule.next();
             Self {
                 schedule: Schedule::Cron(schedule),

influxdb3_server/src/http.rs

@@ -1385,10 +1385,8 @@ fn json_content_type(headers: &HeaderMap) -> bool {
         return false;
     };
 
-    let is_json_content_type = mime.type_() == "application"
-        && (mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json"));
-
-    is_json_content_type
+    mime.type_() == "application"
+        && (mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json"))
 }
 
 #[derive(Debug, Deserialize)]
@@ -1784,11 +1782,7 @@ pub(crate) async fn route_request(
     let path = uri.path();
     // admin token creation should be allowed without authentication
     // and any endpoints that are disabled
-    if path == all_paths::API_V3_CONFIGURE_ADMIN_TOKEN
-        || paths_without_authz
-            .iter()
-            .any(|disabled_authz_path| *disabled_authz_path == path)
-    {
+    if path == all_paths::API_V3_CONFIGURE_ADMIN_TOKEN || paths_without_authz.contains(&path) {
         trace!(?uri, "not authenticating request");
     } else {
         trace!(?uri, "authenticating request");

influxdb3_write/src/lib.rs

@@ -247,14 +247,13 @@ impl PersistedSnapshot {
     }
 
     pub fn overall_db_table_file_counts(host_snapshots: &[PersistedSnapshot]) -> (u64, u64, u64) {
-        let overall_counts = host_snapshots.iter().fold((0, 0, 0), |mut acc, item| {
+        host_snapshots.iter().fold((0, 0, 0), |mut acc, item| {
             let (db_count, table_count, file_count) = item.db_table_and_file_count();
             acc.0 += db_count;
             acc.1 += table_count;
             acc.2 += file_count;
             acc
-        });
-        overall_counts
+        })
     }
 }
 

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.86.0"
+channel = "1.87.0"
 components = ["rustfmt", "clippy", "rust-analyzer", "rust-src"]