refactor(ics24-host): remove From<&str> to avoid panic on host

Author: catconcat

ibc-core/ics03-connection/types/src/connection.rs

@@ -1,6 +1,7 @@
 //! Defines the types that define a connection
 
 use core::fmt::{Display, Error as FmtError, Formatter};
+use core::str::FromStr;
 use core::time::Duration;
 use core::u64;
 
@@ -210,8 +211,12 @@ impl TryFrom<RawConnectionEnd> for ConnectionEnd {
         if state == State::Uninitialized {
             return ConnectionEnd::new(
                 State::Uninitialized,
-                "07-tendermint-0".into(),
-                Counterparty::new("07-tendermint-0".into(), None, CommitmentPrefix::empty()),
+                ClientId::from_str("07-tendermint-0").expect("should not fail"),
+                Counterparty::new(
+                    ClientId::from_str("07-tendermint-0").expect("should not fail"),
+                    None,
+                    CommitmentPrefix::empty(),
+                ),
                 Vec::new(),
                 ZERO_DURATION,
             );

ibc-core/ics24-host/types/src/identifiers/client_id.rs

@@ -76,12 +76,6 @@ impl FromStr for ClientId {
     }
 }
 
-impl From<&str> for ClientId {
-    fn from(s: &str) -> Self {
-        Self::from_str(s).expect("Invalid client id")
-    }
-}
-
 /// Equality check against string literal (satisfies &ClientId == &str).
 /// ```
 /// use core::str::FromStr;