Skip to content

Commit 7031b8c

Browse files
committed
rm prefix from Packet struct
1 parent aacc9b8 commit 7031b8c

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

ibc-eureka-core/ics04-channel/types/src/events/mod.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -554,9 +554,9 @@ impl SendPacket {
554554
timeout_height_attr_on_b: packet.header.timeout_height_on_b.into(),
555555
timeout_timestamp_attr_on_b: packet.header.timeout_timestamp_on_b.into(),
556556
seq_attr_on_a: packet.header.seq_on_a.into(),
557-
port_id_attr_on_a: payload.header.source_port.1.into(),
557+
port_id_attr_on_a: payload.header.source_port.into(),
558558
chan_id_attr_on_a: packet.header.target_client_on_source.into(),
559-
port_id_attr_on_b: payload.header.target_port.1.into(),
559+
port_id_attr_on_b: payload.header.target_port.into(),
560560
chan_id_attr_on_b: packet.header.source_client_on_target.into(),
561561
}
562562
}
@@ -652,9 +652,9 @@ impl ReceivePacket {
652652
timeout_height_attr_on_b: packet.header.timeout_height_on_b.into(),
653653
timeout_timestamp_attr_on_b: packet.header.timeout_timestamp_on_b.into(),
654654
seq_attr_on_a: packet.header.seq_on_a.into(),
655-
port_id_attr_on_a: payload.header.source_port.1.into(),
655+
port_id_attr_on_a: payload.header.source_port.into(),
656656
chan_id_attr_on_a: packet.header.target_client_on_source.into(),
657-
port_id_attr_on_b: payload.header.target_port.1.into(),
657+
port_id_attr_on_b: payload.header.target_port.into(),
658658
chan_id_attr_on_b: packet.header.source_client_on_target.into(),
659659
}
660660
}
@@ -751,9 +751,9 @@ impl WriteAcknowledgement {
751751
timeout_height_attr_on_b: packet.header.timeout_height_on_b.into(),
752752
timeout_timestamp_attr_on_b: packet.header.timeout_timestamp_on_b.into(),
753753
seq_attr_on_a: packet.header.seq_on_a.into(),
754-
port_id_attr_on_a: payload.header.source_port.1.into(),
754+
port_id_attr_on_a: payload.header.source_port.into(),
755755
chan_id_attr_on_a: packet.header.target_client_on_source.into(),
756-
port_id_attr_on_b: payload.header.target_port.1.into(),
756+
port_id_attr_on_b: payload.header.target_port.into(),
757757
chan_id_attr_on_b: packet.header.source_client_on_target.into(),
758758
acknowledgement: acknowledgement.into(),
759759
}
@@ -853,9 +853,9 @@ impl AcknowledgePacket {
853853
timeout_height_attr_on_b: packet.header.timeout_height_on_b.into(),
854854
timeout_timestamp_attr_on_b: packet.header.timeout_timestamp_on_b.into(),
855855
seq_on_a: packet.header.seq_on_a.into(),
856-
port_id_attr_on_a: payload.header.source_port.1.into(),
856+
port_id_attr_on_a: payload.header.source_port.into(),
857857
chan_id_attr_on_a: packet.header.target_client_on_source.into(),
858-
port_id_attr_on_b: payload.header.target_port.1.into(),
858+
port_id_attr_on_b: payload.header.target_port.into(),
859859
chan_id_attr_on_b: packet.header.source_client_on_target.into(),
860860
}
861861
}
@@ -943,9 +943,9 @@ impl TimeoutPacket {
943943
timeout_height_attr_on_b: packet.header.timeout_height_on_b.into(),
944944
timeout_timestamp_attr_on_b: packet.header.timeout_timestamp_on_b.into(),
945945
seq_attr_on_a: packet.header.seq_on_a.into(),
946-
port_id_attr_on_a: payload.header.source_port.1.into(),
946+
port_id_attr_on_a: payload.header.source_port.into(),
947947
chan_id_attr_on_a: packet.header.target_client_on_source.into(),
948-
port_id_attr_on_b: payload.header.target_port.1.into(),
948+
port_id_attr_on_b: payload.header.target_port.into(),
949949
chan_id_attr_on_b: packet.header.source_client_on_target.into(),
950950
}
951951
}

ibc-eureka-core/ics04-channel/types/src/msgs/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ pub enum PacketMsg {
3030

3131
pub fn packet_msg_to_port_id(msg: &PacketMsg) -> &PortId {
3232
match msg {
33-
PacketMsg::Recv(msg) => &msg.packet.payloads[0].header.target_port.1,
34-
PacketMsg::Ack(msg) => &msg.packet.payloads[0].header.source_port.1,
35-
PacketMsg::Timeout(msg) => &msg.packet.payloads[0].header.source_port.1,
33+
PacketMsg::Recv(msg) => &msg.packet.payloads[0].header.target_port,
34+
PacketMsg::Ack(msg) => &msg.packet.payloads[0].header.source_port,
35+
PacketMsg::Timeout(msg) => &msg.packet.payloads[0].header.source_port,
3636
}
3737
}

ibc-eureka-core/ics04-channel/types/src/packet.rs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//! Defines the packet type
22
use ibc_eureka_core_client_types::Height;
3-
use ibc_eureka_core_commitment_types::commitment::CommitmentPrefix;
43
use ibc_eureka_core_host_types::error::DecodingError;
54
use ibc_eureka_core_host_types::identifiers::{ChannelId, PortId, Sequence};
65
use ibc_primitives::prelude::*;
@@ -105,8 +104,8 @@ pub struct PacketHeader {
105104
#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
106105
#[derive(Debug, Clone, Hash, PartialEq, Eq)]
107106
pub struct PayloadHeader {
108-
pub source_port: (CommitmentPrefix, PortId),
109-
pub target_port: (CommitmentPrefix, PortId),
107+
pub source_port: PortId,
108+
pub target_port: PortId,
110109
}
111110

112111
#[cfg_attr(
@@ -196,7 +195,7 @@ impl core::fmt::Display for Packet {
196195
write!(
197196
f,
198197
"src_port:{}, dst_port:{}",
199-
payload.header.source_port.1, payload.header.target_port.1
198+
payload.header.source_port, payload.header.target_port
200199
)?;
201200
}
202201
Ok(())
@@ -247,8 +246,8 @@ impl TryFrom<RawPacket> for Packet {
247246
// TODO(rano): support multi payload; currently only one payload is supported
248247
payloads: vec![Payload {
249248
header: PayloadHeader {
250-
source_port: (CommitmentPrefix::empty(), raw_pkt.source_port.parse()?),
251-
target_port: (CommitmentPrefix::empty(), raw_pkt.destination_port.parse()?),
249+
source_port: raw_pkt.source_port.parse()?,
250+
target_port: raw_pkt.destination_port.parse()?,
252251
},
253252
data: raw_pkt.data,
254253
}],
@@ -265,8 +264,8 @@ impl From<Packet> for RawPacket {
265264
timeout_height: packet.header.timeout_height_on_b.into(),
266265
timeout_timestamp: packet.header.timeout_timestamp_on_b.nanoseconds(),
267266
// TODO(rano): support multi payload; currently only one payload is supported
268-
source_port: packet.payloads[0].header.source_port.1.to_string(),
269-
destination_port: packet.payloads[0].header.target_port.1.to_string(),
267+
source_port: packet.payloads[0].header.source_port.to_string(),
268+
destination_port: packet.payloads[0].header.target_port.to_string(),
270269
data: packet.payloads[0].data.clone(),
271270
}
272271
}

0 commit comments

Comments
 (0)