refactor: wrap ClientId in ChannelId
#1370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rnbguy
changed the title
ClientId in ChannelIdClientId in ChannelId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1367
Description
In Eureka, we are using client identifiers to identify channels. So we wrap
ClientIdinChannelId. This is rudimentary for now. We will think about a better representation later.Caution
We need to change the base to
feat/ibc-eurekawhen #1369 is merged.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.