feat: open login browser directly when agent is logging in (#22)

Author: liamcervante

internal/api/events/metadata.go

@@ -36,6 +36,18 @@ func RegisterMetadata(key string, value interface{}) {
 	metadata[key] = value
 }
 
+// GetMetadata retrieves the value for the specified metadata, and false if it doesn't
+// exist or the type is wrong.
+func GetMetadata[V any](key string) (V, bool) {
+	value, ok := metadata[key]
+	if !ok {
+		var v V
+		return v, false
+	}
+	v, ok := value.(V)
+	return v, ok
+}
+
 func stripVersion(v string) string {
 	parsed, err := semver.NewVersion(v)
 	if err != nil {

pkg/auth/browser/browser.go

@@ -24,8 +24,17 @@ func Open(url string) error {
 }
 
 // WaitAndOpen prints a message and waits for the user to press Enter before opening the specified URL.
-// It stops waiting and does not open the browser if the context is cancelled.
-func WaitAndOpen(ctx context.Context, url string) {
+// It stops waiting and does not open the browser if the context is canceled.
+func WaitAndOpen(ctx context.Context, url string, automatic bool) {
+	if automatic {
+		err := Open(url)
+		if err != nil {
+			fmt.Printf("Failed to open browser: %v\n", err)
+			fmt.Println("Please open the above URL manually.")
+		}
+		return
+	}
+
 	fmt.Printf("\nPress Enter to open the browser automatically...\n")
 
 	go func() {

pkg/auth/device_flow.go

@@ -4,11 +4,14 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/infracost/cli/internal/api/events"
 	"github.com/infracost/cli/pkg/auth/browser"
 	"golang.org/x/oauth2"
 )
 
 func (c *Config) DeviceFlow(ctx context.Context) (oauth2.TokenSource, *oauth2.Token, error) {
+	caller, _ := events.GetMetadata[string]("caller")
+	
 	config := c.OAuth2Config()
 	verifier := oauth2.GenerateVerifier()
 
@@ -22,7 +25,7 @@ func (c *Config) DeviceFlow(ctx context.Context) (oauth2.TokenSource, *oauth2.To
 
 	browserCtx, cancel := context.WithCancel(ctx)
 	defer cancel()
-	browser.WaitAndOpen(browserCtx, response.VerificationURIComplete)
+	browser.WaitAndOpen(browserCtx, response.VerificationURIComplete, len(caller) > 0)
 
 	token, err := config.DeviceAccessToken(ctx, response, oauth2.VerifierOption(verifier))
 	if err != nil {

pkg/auth/pkce.go

@@ -10,11 +10,14 @@ import (
 	"sync"
 	"time"
 
+	"github.com/infracost/cli/internal/api/events"
 	"github.com/infracost/cli/pkg/auth/browser"
 	"golang.org/x/oauth2"
 )
 
 func (c *Config) PKCE(ctx context.Context) (oauth2.TokenSource, *oauth2.Token, error) {
+	caller, _ := events.GetMetadata[string]("caller")
+
 	config := c.OAuth2Config()
 
 	verifier := oauth2.GenerateVerifier()
@@ -80,7 +83,7 @@ func (c *Config) PKCE(ctx context.Context) (oauth2.TokenSource, *oauth2.Token, e
 	fmt.Printf("Please go to the following URL to log in:\n%s\n", authURL)
 	browserCtx, cancel := context.WithCancel(ctx)
 	defer cancel()
-	browser.WaitAndOpen(browserCtx, authURL)
+	browser.WaitAndOpen(browserCtx, authURL, len(caller) > 0)
 
 	wg.Wait() // wait for the server to finish