fix: return needs login correctly

owenrumney · owenrumney · commit 9ed07025ce37 · 2026-03-10T17:57:18.000Z
diff --git a/internal/lsp/resource_details.go b/internal/lsp/resource_details.go
@@ -115,10 +115,10 @@ func (s *Server) HandleResourceDetails(_ context.Context, params json.RawMessage
 		}
 
 		detail := buildResourceDetail(r, violationsByAddr[r.Name], tagViolationsByAddr[r.Name])
-		return ResourceDetailsResult{Resource: &detail}, nil
+		return ResourceDetailsResult{Resource: &detail, NeedsLogin: needsLogin}, nil
 	}
 
-	return ResourceDetailsResult{}, nil
+	return ResourceDetailsResult{NeedsLogin: needsLogin}, nil
 }
 
 func buildResourceDetail(r scanner.ResourceResult, violations []scanner.FinopsViolation, tagViolations []scanner.TagViolation) ResourceDetail {

Original file line number	Diff line number	Diff line change
`@@ -115,10 +115,10 @@ func (s *Server) HandleResourceDetails(_ context.Context, params json.RawMessage`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`detail := buildResourceDetail(r, violationsByAddr[r.Name], tagViolationsByAddr[r.Name])`
`118`		`- return ResourceDetailsResult{Resource: &detail}, nil`
	`118`	`+ return ResourceDetailsResult{Resource: &detail, NeedsLogin: needsLogin}, nil`
`119`	`119`	`}`
`120`	`120`
`121`		`- return ResourceDetailsResult{}, nil`
	`121`	`+ return ResourceDetailsResult{NeedsLogin: needsLogin}, nil`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`func buildResourceDetail(r scanner.ResourceResult, violations []scanner.FinopsViolation, tagViolations []scanner.TagViolation) ResourceDetail {`