[common] Update task names for XML reporting

Author: elfiesmelfie

roles/common/tasks/container_test.yml

@@ -6,7 +6,9 @@
   changed_when: false
   register: container_status
 
-- name: Verify container status {{ common_container_test_id }}
+- name: |
+    Verify {{ container_name }} container status
+    {{ common_container_test_id }}
   ansible.builtin.assert:
     that:
       - "'unhealthy' not in container_status.stdout"

roles/common/tasks/cr_tests.yml

@@ -1,6 +1,6 @@
 ---
 - name: |
-    Verify that the {{ item.kind }} {{ item.name }} CR exists
+    TEST Verify that the {{ item.kind }} {{ item.name }} CR exists
     {{ common_cr_test_id }}
   ansible.builtin.command:
     cmd: |
@@ -12,14 +12,16 @@
 
   # This is added so that the task name will be rendered correctly
   # If item.condition_type is used and it doesn't exist, then the
-  # literal template text will appear as the task name
+  # literal template text would appear as the task name
   # e.g. "Verify that the {{ item.kind }} {{ item.name }} CR is {{ item.condition_type }}"
+  # and it would appear in the XML output incorrectly as
+  # "verify_that_the_item_kind_item_name_cr_is_item_condition_type"
 - name: Set the condition type
   ansible.builtin.set_fact:
     condition_type: "{{ item.condition_type if item.condition_type is defined else '' }}"
 
 - name: |
-    Verify that the {{ item.kind }} {{ item.name }} CR is {{ condition_type }}
+    {{ 'TEST' if condition_type | length > 0 }} Verify that the {{ item.kind }} {{ item.name }} CR is {{ condition_type }}
     {{ common_cr_ready_test_id if condition_type | length > 0 }}
   ansible.builtin.command:
     cmd: |

roles/common/tasks/crd_tests.yml

@@ -6,7 +6,9 @@
   changed_when: false
   register: output
 
-- name: Verify CRD is found "{{ common_crd_test_id }}"
+- name: |
+    TEST Verify CRD {{ item }} is found
+    {{ common_crd_test_id }}
   ansible.builtin.assert:
     that:
       - "'NotFound' not in output.stderr"

roles/common/tasks/endpoint_tests.yml

@@ -6,7 +6,9 @@
   changed_when: false
   register: output
 
-- name: Check that endpoint exist {{ common_endpoint_test_id }}
+- name: |
+    TEST Check that {{ item[0] }} endpoint exists
+    {{ common_endpoint_test_id }}
   ansible.builtin.assert:
     that:
       - output.stdout != ""

roles/common/tasks/manifest_tests.yml

@@ -13,10 +13,12 @@
   register: pack_name
   changed_when: false
 
-- name: Get packagemanifest "{{ common_manifest_test_id }}"
+- name: |
+    TEST Get {{ item }} packagemanifest
+    {{ common_manifest_test_id }}
   ansible.builtin.shell:
     cmd: |
       oc get packagemanifests | grep "{{ pack_name.stdout }}" | wc -l
   register: num_found 
   changed_when: false
-  failed_when: num_expected.stdout != num_found.stdout
+  failed_when: num_expected.stdout != num_found.stdout

roles/common/tasks/pod_tests.yml

@@ -11,7 +11,9 @@
         - podinstance.stdout_lines | length != 1
       changed_when: false
 
-    - name: Check pod {{ common_pod_test_id }}
+    - name: |
+        TEST Check {{ item }} pod
+        {{ common_pod_test_id }}
       ansible.builtin.command:
         cmd: |
           oc get pod -n "{{ common_pod_nspace }}" "{{ podinstance.stdout }}"

roles/common/tasks/project_tests.yml

@@ -6,7 +6,9 @@
   changed_when: false
   register: output
 
-- name: Verify project is found "{{ common_project_test_id }}"
+- name: |
+   TEST Verify {{ item }} project is found
+     "{{ common_project_test_id }}"
   ansible.builtin.assert:
     that:
       - "'NotFound' not in output.stderr"

roles/common/tasks/subscription_tests.yml

@@ -6,7 +6,9 @@
   changed_when: false
   register: output
 
-- name: Check that subscription exist {{ common_subscription_test_id }}
+- name: |
+    TEST Check that {{ item }} subscription exists
+    {{ common_subscription_test_id }}
   ansible.builtin.assert:
     that:
       - "'NotFound' not in output.stderr"