[common] Update the optional CR status test

Author: elfiesmelfie

roles/common/tasks/cr_tests.yml

@@ -10,25 +10,20 @@
   failed_when:
     - result.rc != 0
 
-  # This is added so that the test is not included when it shouldn't be
-  # If the when is added to the test task, the resulting task name in
-  # XML is "verify_that_the_item_kind__item_name_cr_is_item_condition"
-  # Which might be okay, if polarion ignores the unknown testcases
-  # If polarion is ignoring the unknown testcases, then we don't need to
-  # mark anything with a test prefix
-- name: Determine whether to mark the CR ready test as a test
+  # This is added so that the test is not marked when it shouldn't be
+  # If the item.condition_type is referenced in the TEST task, without
+  # being defined, the resulting task name in XML is
+  # "verify_that_the_item_kind_item_name_cr_is_item_condition_type"
+- name: Set the condition type
   ansible.builtin.set_fact:
-    run_cr_ready_test: true
-  when:
-    - common_cr_ready_test_id is defined
-    - item.condition_type is defined
+    condition_type: "{{ item.condition_type if item.condition_type is defined else '' }}"
 
 - name: |
-    {{ 'TEST' if run_cr_ready_test | bool }} Verify that the {{ item.kind }} {{ item.name }} CR is {{ item.condition_type }}
-    {{ common_cr_ready_test_id }}
+    {{ 'TEST' if condition_type | length > 0 }} Verify that the {{ item.kind }} {{ item.name }} CR is {{ condition_type }}
+    {{ common_cr_ready_test_id if condition_type | length > 0 }}
   ansible.builtin.command:
     cmd: |
-      oc get {{ item.kind }} {{ item.name }} -o jsonpath='{.status.conditions[?(@.type=="{{ item.condition_type }}")].status}{"\n"}'
+      oc get {{ item.kind }} {{ item.name }} -o jsonpath='{.status.conditions[?(@.type=="{{ condition_type }}")].status}{"\n"}'
   register: result
   changed_when: false
   failed_when: