Delete RHOSO Test id's in roles/common/tasks fvt tests

Author: myadla

roles/common/README.md

@@ -26,8 +26,6 @@ Variable required for all tasks to run
 
 For pod_tests.yml tasks:
 
-    common_pod_test_id
-      - polarion ID number for each test.
     common_pod_list
       - list of pods to validate
     common_pod_status_str
@@ -38,63 +36,47 @@ For pod_tests.yml tasks:
 
 For subscription_tests.yml tasks:
 
-    common_subscription_test_id
-      - polarion ID number for each test
     common_subscription_nspace
       - namespace
     common_subscription_list
       - list of subscription to validate
 
 For crd_tests.yml tasks:
 
-    common_crd_test_id
-      - polarion ID number for each test.
     common_crd_list
       - list of crd to validate
 
 For endpoint_tests.yml tasks:
 
-    common_endpoint_test_id
-      - polarion ID number for each test.
     common_endpoint_list
       - list of endpoints to validate
     openstack_cmd
       - The command used to run openstack
 
 For project_tests.yml tasks:
 
-    common_project_test_id
-      - polarion ID number for each test
     common_project_list
       - list of projects to validate
 
 For service_tests.yml tasks:
 
-    common_service_test_id
-      - polarion ID number for each test
     common_service_nspace
       - namespace
     common_service_list
       - list of services to validate
 
 For file_tests.yml tasks:
 
-    common_file_test_id
-      - polarion ID number for each test
     common_file_list
       - list of files to validate
 
 For manifest_tests.yml tasks:
 
-     manifest_test_id
-       - polarion ID number for each test
      manifest_list
        - list of package manifests to validate
 
 For cr\_tests.yml tasks:
 
-    common\_cr\_test\_id is defined
-       - polarion ID number for each test that a CR exists
     common\_cr\_list is defined
        - list of CRs to check
         Each dict should include the following keys: kind, name
@@ -103,8 +85,6 @@ For cr\_tests.yml tasks:
            kind: metricstorage
            name: metric-storage
            condition\_type: Ready
-    common\_cr\_ready\_test\_id is optionally defined
-       - polarion ID number for each test of readiness of the CR
 
 
 
@@ -132,7 +112,6 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_pod_test_id: "RHOSO-12752"
           common_pod_status_str: "Running"
           common_pod_nspace: openstack
           common_pod_list:
@@ -142,7 +121,6 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_subscription_test_id: "RHOSO-12678"
           common_subscription_nspace: openshift-operators-redhat
           common_subscription_l :
             - loki-operator
@@ -151,7 +129,6 @@ can be set at the play level.
         ansible.builtin.include_role:
           name: common
         vars:
-            common_container_test_id: "RHOSO-12753"
             common_container_list:
                 - ceilometer_agent_compute
                 - ceilometer_agent_ipmi
@@ -163,7 +140,6 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_endpoint_test_id: "RHOSO-12682"
           common_endpoint_list:
             - [nova,compute,public]
             - [nova,compute,internal]
@@ -173,7 +149,6 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_project_test_id: "RHOSO-12668"
           common_project_list:
             - openshift-openstack-infra
             - openshift
@@ -182,7 +157,6 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_service_test_id: "RHOSO-12675"
           common_service_nspace: openshift-logging
           common_service_list:
             - cluster-logging-operator-metrics
@@ -207,15 +181,13 @@ can be set at the play level.
         ansible.builtin.import_role:
           name: common
         vars:
-          common_file_test_id: "RHOSO-12754"
           common_file_list:
             - /etc/rsyslog.d/10-telemetry.conf
 
       - name: "Verify crd"
         ansible.builtin.import_role:
           name: common
         vars:
-          common_crd_test_id : "crd_test_id"
           common_crd_list:
             - list of crd to validate
 

roles/common/defaults/main.yml

@@ -1,14 +1,2 @@
 ---
-openstack_cmd: "openstack"
-
-common_crd_test_id: "RHOSO-XXXX"
-common_cr_test_id: "RHOSO-XXXX"
-common_cr_ready_test_id: "RHOSO-XXXX"
-common_container_test_id: "RHOSO-XXXX"
-common_endpoint_test_id: "RHOSO-XXXX"
-common_file_test_id: "RHOSO-XXXX"
-common_manifest_test_id: "RHOSO-XXXX"
-common_pod_test_id: "RHOSO-XXXX"
-common_project_test_id: "RHOSO-XXXX"
-common_service_test_id: "RHOSO-XXXX"
-common_subscription_test_id: "RHOSO-XXXX"
+openstack_cmd: "openstack"

roles/common/tasks/container_test.yml

@@ -25,7 +25,6 @@
 
 - name: |
     TEST Verify {{ container_name }} container status
-    {{ common_container_test_id }}
   ansible.builtin.assert:
     that:
       - "container_status.stdout | length != 0"

roles/common/tasks/cr_tests.yml

@@ -1,7 +1,6 @@
 ---
 - name: |
     TEST Verify that the {{ item.kind }} {{ item.name }} CR exists
-    {{ common_cr_test_id }}
   ansible.builtin.command:
     cmd: |
       oc get {{ item.kind }} {{ item.name }}
@@ -10,7 +9,7 @@
   failed_when:
     - result.rc != 0
 
-- name: Verify that a CR is ready {{ common_cr_ready_test_id }}
+- name: Verify that a CR is ready
   ansible.builtin.command:
     cmd: |
       oc get {{ item.kind }} {{ item.name }} -o jsonpath='{.status.conditions[?(@.type=="{{ item.condition_type }}")].status}{"\n"}'
@@ -19,5 +18,4 @@
   failed_when:
     - result.stdout != "True"
   when:
-    - common_cr_ready_test_id is defined
     - item.condition_type is defined

roles/common/tasks/crd_tests.yml

@@ -8,7 +8,6 @@
 
 - name: |
     TEST Verify CRD {{ item }} is found
-    {{ common_crd_test_id }}
   ansible.builtin.assert:
     that:
       - "'NotFound' not in output.stderr"

roles/common/tasks/endpoint_tests.yml

@@ -8,7 +8,6 @@
 
 - name: |
     TEST Check that {{ item[0] }} {{ item[2] }} endpoint exists
-    {{ common_endpoint_test_id }}
   ansible.builtin.assert:
     that:
       - output.stdout != ""

roles/common/tasks/file_tests.yml

@@ -6,7 +6,6 @@
 
 - name: |
     TEST Verify the file {{ item }} exists
-    {{ common_file_test_id }}
   ansible.builtin.assert:
     that:
       - fstats.stat.exists

roles/common/tasks/main.yml

@@ -1,7 +1,6 @@
 ---
 - name: "Run pod tests"
   when:
-    - common_pod_test_id is defined
     - common_pod_list is defined
     - common_pod_nspace is defined
     - common_pod_status_str is defined
@@ -23,51 +22,44 @@
 
 - name: "Run project tests"
   when:
-    - common_project_test_id is defined
     - common_project_list is defined
   ansible.builtin.include_tasks: "project_tests.yml"
   loop: "{{ common_project_list }}"
 
 - name: "Run service tests"
   when:
-    - common_service_test_id is defined
     - common_service_nspace is defined
     - common_service_list is defined
   ansible.builtin.include_tasks: "service_tests.yml"
   loop: "{{ common_service_list }}"
 
 - name: "Run file tests"
   when:
-    - common_file_test_id is defined
     - common_file_list is defined
   ansible.builtin.include_tasks: "file_tests.yml"
   loop: "{{ common_file_list }}"
 
 - name: "Run manifest tests"
   when:
-    - common_manifest_test_id is defined
     - common_manifest_list is defined
   ansible.builtin.include_tasks: "manifest_tests.yml"
   loop: "{{ common_manifest_list }}"
 
 - name: "Run crd tests"
   when:
-    - common_crd_test_id is defined
     - common_crd_list is defined
   ansible.builtin.include_tasks: "crd_tests.yml"
   loop: "{{ common_crd_list }}"
 
 - name: "Run CR tests"
   when:
-    - common_cr_test_id is defined
     - common_cr_list is defined
   ansible.builtin.include_tasks: "cr_tests.yml"
   loop: "{{ common_cr_list }}"
 
 - name: "Verify container tests"
   when:
     - common_container_list is defined
-    - common_container_test_id is defined
   ansible.builtin.include_tasks: "container_test.yml"
   loop: "{{ common_container_list }}"
   loop_control:

roles/common/tasks/manifest_tests.yml

@@ -15,7 +15,6 @@
 
 - name: |
     TEST Get {{ item }} packagemanifest
-    {{ common_manifest_test_id }}
   ansible.builtin.shell:
     cmd: |
       oc get packagemanifests | grep "{{ pack_name.stdout }}" | wc -l

roles/common/tasks/pod_tests.yml

@@ -13,7 +13,6 @@
 
     - name: |
         TEST Check {{ item }} pod is {{ common_pod_status_str }} in {{ common_pod_nspace }} namespace
-        {{ common_pod_test_id }}
       ansible.builtin.command:
         cmd: |
           oc get pod -n "{{ common_pod_nspace }}" "{{ podinstance.stdout }}"