Skip to content

Commit 44505a8

Browse files
Revert "[ADD] l10n_ar_edi_ux: mejora de rendimiento en actualizacion masiva de partners"
This reverts commit bb3bb71. closes #397 Signed-off-by: Filoquin adhoc <maq@adhoc.com.ar>
1 parent bb3bb71 commit 44505a8

File tree

5 files changed

+4
-49
lines changed

5 files changed

+4
-49
lines changed

l10n_ar_edi_ux/__manifest__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
'name': 'Argentinian Electronic Invoicing UX',
3-
'version': "16.0.1.10.0",
3+
'version': "16.0.1.11.0",
44
'category': 'Localization/Argentina',
55
'sequence': 14,
66
'author': 'ADHOC SA',

l10n_ar_edi_ux/models/res_partner.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@
88
class ResPartner(models.Model):
99
_inherit = 'res.partner'
1010

11-
12-
failed_to_update = fields.Boolean(
13-
string="Falló actualización AFIP",
14-
tracking=True)
15-
1611
def update_partner_data_from_afip(self):
1712
""" Funcion que llama al wizard para actualizar data de partners desde afip sin abrir wizard.
1813
Podríamos mejorar pasando un argumento para sobreescribir o no valores que esten o no definidos

l10n_ar_edi_ux/views/res_partner_view.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,4 @@
1212
</field>
1313
</record>
1414

15-
<record id="res_partner_view_search" model="ir.ui.view">
16-
<field name="name">res.partner.search.inherit</field>
17-
<field name="model">res.partner</field>
18-
<field name="inherit_id" ref="base.view_res_partner_filter"/>
19-
<field name="arch" type="xml">
20-
<xpath expr="//filter[@name='l10n_ar_afip_responsibility_type_id_filter']" position="after">
21-
<group>
22-
<filter string="Falló actualización AFIP" name="failed_to_update" domain="[('failed_to_update', '=', True), ('country_code', '=', 'AR')]"/>
23-
</group>
24-
</xpath>
25-
<separator/>
26-
</field>
27-
</record>
2815
</odoo>

l10n_ar_edi_ux/wizards/res_partner_update_from_padron_wizard.py

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import re
2-
31
from odoo import models, api, fields, _
42
from ast import literal_eval
53
from odoo.exceptions import UserError
@@ -119,8 +117,6 @@ def get_fields(self):
119117
required=True,
120118
)
121119

122-
wizard_error = fields.Html()
123-
124120
@api.onchange('partner_id')
125121
def change_partner(self):
126122
self.ensure_one()
@@ -173,13 +169,8 @@ def _update(self):
173169
def automatic_process_cb(self):
174170
for partner in self.partner_ids:
175171
self.partner_id = partner.id
176-
try:
177-
self.change_partner()
178-
self._update()
179-
self.partner_id.failed_to_update = False
180-
except:
181-
self.partner_id.failed_to_update = True
182-
continue
172+
self.change_partner()
173+
self._update()
183174
self.write({'state': 'finished'})
184175
return {
185176
'type': 'ir.actions.act_window',
@@ -218,33 +209,16 @@ def _next_screen(self):
218209
values.update({
219210
'partner_id': partner.id,
220211
'state': 'selection',
221-
'wizard_error': False,
222212
})
223213
else:
224214
values.update({
225215
'state': 'finished',
226-
'wizard_error': False,
227-
'partner_id': False,
228216
})
229217

230218
self.write(values)
231219
# because field is not changed, view is distroyed and reopen, on change
232220
# is not called an we call it manually
233-
try:
234-
self.change_partner()
235-
self.partner_id.failed_to_update = False
236-
except (UserError) as exp:
237-
self.partner_id.failed_to_update = True
238-
239-
#Procesamos el error que nos devuelve afip
240-
patron = re.compile(r"'error': \['(.*?)'\]")
241-
resultado = patron.search(str(exp))
242-
if resultado:
243-
error = resultado.group(1)
244-
else:
245-
error = str(exp)
246-
self.wizard_error = '<div class= "alert alert-warning" role="alert" style="margin-bottom:0px;" >' + error + '</div>'
247-
221+
self.change_partner()
248222
return {
249223
'type': 'ir.actions.act_window',
250224
'res_model': self._name,

l10n_ar_edi_ux/wizards/res_partner_update_from_padron_wizard_view.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
</header>
5050
<sheet>
5151
<h2 attrs="{'invisible': [('state', '!=', 'finished')]}">There are no more partners to update for this request...</h2>
52-
<field name="wizard_error" readonly="1" attrs="{'invisible': not wizard_error}"/>
5352
<p class="oe_grey" attrs="{'invisible': [('state', '!=', ('option'))]}">
5453
Only Partners with cuit are going to be updated.<br/>
5554
Select the list of fields you want to update.

0 commit comments

Comments
 (0)