[FIX] l10n_ar_currency_update: actualización de moneda.

Ticket: 110979
Cuando la moneda de la compañía es ARS pero el usuario le cambió el nombre por ejemplo a "PES" entonces no se logra hacer la actualización de las tasas de cambio porque no estamos actualizando la moneda de la compañía y odoo lo requiere (por más de que el tipo de cambio sea el mismo todos los días).

closes #911

X-original-commit: c76cade
Signed-off-by: Julia Elizondo - jue (#l10n) <jue@adhoc.com.ar>
Signed-off-by: Pablo Montenegro - pam (#l10n) <pam@adhoc.com.ar>

Author: pablohmontenegro

l10n_ar_currency_update/models/res_company.py

@@ -160,7 +160,7 @@ def _generate_currency_rates(self, parsed_data):
                         ("company_id", "=", company.id),
                     ]
                 )
-                if currency == "ARS":
+                if currency == company.currency_id.name:
                     continue
                 if already_existing_rate:
                     new_parsed_data.pop(currency)

l10n_ar_currency_update/tests/test_l10n_ar_currency_update.py

@@ -5,46 +5,78 @@
 import datetime
 from unittest.mock import patch
 
-from odoo.addons.account.tests.common import AccountTestInvoicingCommon
-from odoo.tests import tagged
+from odoo.tests import TransactionCase, tagged
 
 
 @tagged("post_install", "-at_install")
-class TestL10nArCurrencyUpdate(AccountTestInvoicingCommon):
+class TestL10nArCurrencyUpdate(TransactionCase):
     @classmethod
-    @AccountTestInvoicingCommon.setup_chart_template("ar_ri")
     def setUpClass(cls):
         super().setUpClass()
         cls.ARS = cls.env.ref("base.ARS")
         cls.USD = cls.env.ref("base.USD")
         cls.EUR = cls.env.ref("base.EUR")
 
-        # Activamos monedas por las dudas
+        # Activamos monedas
         cls.USD.active = True
         cls.EUR.active = True
         cls.utils_path = "odoo.addons.l10n_ar_currency_update.models.res_company.ResCompany"
 
     def test_ARS(self):
-        """When the base currency is ARS"""
-        msg_error = "Should not be any rate for this currency and company to continue with the test"
-        self.assertEqual(self.env.company.currency_id, self.ARS)
-        self.assertEqual(self.ARS.rate, 1.0, msg_error)
-        self.assertEqual(self.USD.rate, 1.0, msg_error)
-        self.assertEqual(self.EUR.rate, 1.0, msg_error)
-
-        test_date = datetime.date(2024, 9, 24)
+        """Cuando se hace la actualización de monedas desde ARCA, siempre tenemos que validar que se actualice la moneda local (ARS) aunque su tipo de cambio sea 1.0 .
+        Esto es requerido por validaciones de contabilidad en método _generate_currency_rates de src/enterprise/currency_rate_live/models/res_config_settings.py.
+        Si no actualizamos la moneda local, no se crea ningún registro de tipo de cambio para esa fecha y empresa."""
+        test_date = datetime.date(2026, 9, 24)
+
+        # Clean existing rates for test isolation
+        self.env["res.currency.rate"].search(
+            [
+                ("name", "=", test_date),
+                ("company_id", "=", self.env.company.id),
+            ]
+        ).unlink()
+
+        # Configure company to use AFIP provider
+        self.env.company.write(
+            {
+                "currency_provider": "afip",
+                "currency_interval_unit": "daily",
+            }
+        )
+
+        # Mock data must include base currency for enterprise validation
         mocked_res = {
             "ARS": (1.0, test_date),
             "EUR": (0.0009435361546070796, test_date),
             "USD": (0.0010481301358376655, test_date),
         }
 
         with patch(f"{self.utils_path}._parse_afip_data", return_value=mocked_res):
-            self.env.company.update_currency_rates()
+            self.env.company.with_context(l10n_ar_force_create_rate=True).update_currency_rates()
 
-        self.assertEqual(self.ARS.rate, 1.0)
-        self.assertNotEqual(self.USD.rate, 954.08)
-        self.assertNotEqual(self.EUR.rate, 1059.8428)
+        # Base currency WILL have a rate created with rate=1.0 (expected behavior)
+        base_rate = self.env["res.currency.rate"].search(
+            [
+                ("currency_id", "=", self.env.company.currency_id.id),
+                ("name", "=", test_date),
+                ("company_id", "=", self.env.company.id),
+            ]
+        )
+        self.assertTrue(base_rate, "Base currency should have a rate created")
+        self.assertEqual(base_rate.rate, 1.0, "Base currency rate should be 1.0")
+
+        # Verify other currencies got rates created
+        for curr_code in mocked_res.keys():
+            if curr_code != self.env.company.currency_id.name:
+                if curr := self.env["res.currency"].search([("name", "=", curr_code)]):
+                    rate = self.env["res.currency.rate"].search(
+                        [
+                            ("currency_id", "=", curr.id),
+                            ("name", "=", test_date),
+                            ("company_id", "=", self.env.company.id),
+                        ]
+                    )
+                    self.assertTrue(rate, f"{curr_code} should have a rate created")
 
     def test_currency_rate_with_rate_perc(self):
         """Check that the rate percentage is applied only to company 1 when both sync from ARCA"""
@@ -53,8 +85,15 @@ def test_currency_rate_with_rate_perc(self):
         rate_perc = 0.03
         test_date = datetime.date.today()
 
-        # Create a second Argentine company
+        # Create two fresh Argentine companies to avoid currency change issues
         ar_country = self.env.ref("base.ar")
+        company_1 = self.env["res.company"].create(
+            {
+                "name": "Test Argentine Company 1",
+                "country_id": ar_country.id,
+                "currency_id": self.ARS.id,
+            }
+        )
         company_2 = self.env["res.company"].create(
             {
                 "name": "Test Argentine Company 2",
@@ -63,49 +102,49 @@ def test_currency_rate_with_rate_perc(self):
             }
         )
 
-        # Configure the first company (self.env.company) with currency provider AND rate_perc
-        self.env.company.write(
+        # Configure company_1 with currency provider AND rate_perc
+        company_1.write(
             {
                 "currency_provider": "afip",
                 "rate_perc": rate_perc,
                 "currency_interval_unit": "daily",
             }
         )
 
-        # Configure the second company with currency provider but WITHOUT rate_perc
+        # Configure company_2 with currency provider but WITHOUT rate_perc
         company_2.write(
             {
                 "currency_provider": "afip",
                 "currency_interval_unit": "daily",
+                "rate_perc": 0.0,  # Explicitly no markup
             }
         )
 
         # Clean up previous rates for both companies
-        existing_rates = self.env["res.currency.rate"].search(
+        self.env["res.currency.rate"].search(
             [
                 ("currency_id", "=", self.USD.id),
                 ("name", "=", test_date),
-                ("company_id", "in", [self.env.company.id, company_2.id]),
+                ("company_id", "in", [company_1.id, company_2.id]),
             ]
-        )
-        existing_rates.unlink()
+        ).unlink()
 
         # Prepare mock data for AFIP
         mocked_res = {
-            "ARS": (1.0, test_date),
+            "ARS": (1.0, test_date),  # Base currency for both companies
             "USD": (1.0 / base_arca_rate, test_date),
         }
 
         # Execute test logic with patch - call update_currency_rates on both companies
         with patch(f"{self.utils_path}._parse_afip_data", return_value=mocked_res):
-            (self.env.company | company_2).update_currency_rates()
+            (company_1 | company_2).with_context(l10n_ar_force_create_rate=True).update_currency_rates()
 
         # Validate rate creation for company 1 (WITH percentage rate_perc)
         rate_record_company_1 = self.env["res.currency.rate"].search(
             [
                 ("currency_id", "=", self.USD.id),
                 ("name", "=", test_date),
-                ("company_id", "=", self.env.company.id),
+                ("company_id", "=", company_1.id),
             ]
         )
 
@@ -115,15 +154,16 @@ def test_currency_rate_with_rate_perc(self):
         )
 
         # Verify markup was applied correctly for company 1
-        # The inverse rate (ARS per USD unit) should be base_arca_rate * (1 + rate_perc)
-        inverse_rate_company_1 = 1 / rate_record_company_1.rate
-        expected_inverse_rate_company_1 = base_arca_rate * (1 + rate_perc)
+        # In Odoo, rate field = 1 / (ARS per USD)
+        # With markup: ARS_per_USD = base_arca_rate * (1 + rate_perc)
+        # So rate field = 1 / (base_arca_rate * (1 + rate_perc))
+        expected_rate_with_markup = 1.0 / (base_arca_rate * (1 + rate_perc))
 
         self.assertAlmostEqual(
-            inverse_rate_company_1,
-            expected_inverse_rate_company_1,
-            places=2,
-            msg="The inverse rate value (ARS per unit) with markup is incorrect for company 1.",
+            rate_record_company_1.rate,
+            expected_rate_with_markup,
+            places=6,
+            msg="The rate with markup is incorrect for company 1.",
         )
 
         # Validate rate creation for company 2 (WITHOUT rate_perc)
@@ -141,13 +181,13 @@ def test_currency_rate_with_rate_perc(self):
         )
 
         # Verify NO markup was applied for company 2 (base ARCA rate)
-        inverse_rate_company_2 = 1 / rate_record_company_2.rate
+        expected_rate_no_markup = 1.0 / base_arca_rate
 
         self.assertAlmostEqual(
-            inverse_rate_company_2,
-            base_arca_rate,
-            places=2,
-            msg="The inverse rate value (ARS per unit) should be the base ARCA rate for company 2 (no markup).",
+            rate_record_company_2.rate,
+            expected_rate_no_markup,
+            places=6,
+            msg="The rate should be the base ARCA rate for company 2 (no markup).",
         )
 
         # Verify that the rates are different between companies