[MIG] l10n_ar_account_tax_settlement_mendoza, l10n_ar_txt_sire: Migration to 18.0#904
Open
pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
Open
[MIG] l10n_ar_account_tax_settlement_mendoza, l10n_ar_txt_sire: Migration to 18.0#904pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
pablohmontenegro wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR migra dos módulos de la versión 17.0 a la versión 18.0 de Odoo: l10n_ar_txt_sire y l10n_ar_account_tax_settlement_mendoza. La migración incluye cambios arquitectónicos significativos en la forma de manejar retenciones y cálculo de impuestos.
Changes:
- En
l10n_ar_txt_sire: se mueven los campos SIRE desde el modelol10n_ar.payment.withholdingal modeloaccount.payment, adaptándose a la nueva arquitectura de retenciones de Odoo 18. - En
l10n_ar_account_tax_settlement_mendoza: se migra desde configuración directa en impuestos (withholding_type,withholding_python_compute) a la nueva arquitectura basada en posiciones fiscales con fórmulas Python (account.fiscal.position.l10n_ar_tax). - Mejoras generales: actualización de nombres de vistas (tree → list), mensajes de error más claros, y simplificación de código.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| l10n_ar_txt_sire/manifest.py | Actualiza versión a 18.0.1.0.0, marca como instalable, y actualiza referencias de archivos de vista |
| l10n_ar_txt_sire/models/init.py | Cambia import de l10n_ar_payment_withholding a account_payment |
| l10n_ar_txt_sire/models/account_payment.py | Nuevo archivo que redefine campos SIRE en account.payment con @api.onchange actualizado |
| l10n_ar_txt_sire/models/l10n_ar_payment_withholding.py | Archivo eliminado (lógica movida a account_payment) |
| l10n_ar_txt_sire/models/account_journal.py | Actualiza referencias de payment.withholding_id a payment directo, usa line._get_settlement_tax(), mejora mensajes de error |
| l10n_ar_txt_sire/views/account_payment_view.xml | Nueva vista para account.payment (reemplaza vista de withholding eliminada) |
| l10n_ar_txt_sire/views/l10n_ar_payment_withholding_views.xml | Vista eliminada |
| l10n_ar_account_tax_settlement_mendoza/manifest.py | Actualiza versión a 18.0.1.0.0, cambia dependencias (l10n_ar_tax_python, base_import_match), marca como instalable |
| l10n_ar_account_tax_settlement_mendoza/hooks.py | Reescritura completa del post_init_hook para crear configuraciones de fiscal position con fórmulas Python en lugar de configurar impuestos directamente |
| l10n_ar_account_tax_settlement_mendoza/models/init.py | Elimina imports de account_payment y account_tax (ya no necesarios) |
| l10n_ar_account_tax_settlement_mendoza/models/account_payment.py | Archivo eliminado (campo alicuota_mendoza ya no se almacena, se calcula en fórmula) |
| l10n_ar_account_tax_settlement_mendoza/models/account_tax.py | Archivo eliminado (método get_partner_alicuot ya no necesario) |
| l10n_ar_account_tax_settlement_mendoza/models/account_journal.py | Simplifica validaciones usando walrus operator y mejora mensajes de error |
| l10n_ar_account_tax_settlement_mendoza/views/account_payment_view.xml | Vista eliminada (ya no se necesita mostrar alicuota_mendoza en payment) |
| l10n_ar_account_tax_settlement_mendoza/views/afip_activity_view.xml | Actualiza nombre de vista de "tree" a "list" (convención Odoo 18) |
| l10n_ar_account_tax_settlement_mendoza/README.rst | Actualiza documentación para reflejar nueva arquitectura basada en posiciones fiscales |
| l10n_ar_account_tax_settlement/models/account_journal.py | Cambia line.payment_id.name a line.name para obtener número de comprobante correcto |
| account_tax_settlement/models/account_journal.py | Limpieza de formato: elimina concatenaciones innecesarias de strings |
pablohmontenegro
force-pushed
the
18.0-t-47856-pam-1
branch
3 times, most recently
from
cc7d2e3 to
69621b5
Compare
pablohmontenegro
force-pushed
the
18.0-t-47856-pam-1
branch
from
69621b5 to
a09d513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.