up: support controler object cache on repeat fetach

Author: inhere

src/AbstractApplication.php

@@ -121,6 +121,11 @@ abstract class AbstractApplication implements ApplicationInterface
      */
     protected $errorHandler;
 
+    /**
+     * @var Controller[]
+     */
+    protected $groupObjects = [];
+
     /**
      * Class constructor.
      *

src/Application.php

@@ -15,6 +15,7 @@
 use Inhere\Console\Util\Helper;
 use InvalidArgumentException;
 use ReflectionException;
+use RuntimeException;
 use SplFileInfo;
 use function class_exists;
 use function implode;
@@ -266,7 +267,7 @@ public function dispatch(string $name, bool $detachedRun = false)
         }
 
         $cmdId = $name;
-        $this->debugf( 'begin dispatch the input command: %s', $name);
+        $this->debugf('begin dispatch the input command: %s', $name);
 
         // format is: `group action`
         if (strpos($name, ' ') > 0) {
@@ -309,7 +310,7 @@ public function dispatch(string $name, bool $detachedRun = false)
         }
 
         // is controller/group
-        return $this->runAction($info['group'], $info['action'], $info['handler'], $cmdOptions, $detachedRun);
+        return $this->runAction($info, $cmdOptions, $detachedRun);
     }
 
     /**
@@ -355,21 +356,64 @@ protected function runCommand(string $name, $handler, array $options)
     /**
      * Execute an action in a group command(controller)
      *
-     * @param string $group   The group name
-     * @param string $action  Command method, no suffix
-     * @param mixed  $handler The controller class or object
+     * @param array  $info Matched route info
      * @param array  $options
      * @param bool   $detachedRun
      *
      * @return mixed
      * @throws ReflectionException
      */
-    protected function runAction(string $group, string $action, $handler, array $options, bool $detachedRun = false)
+    protected function runAction(array $info,  array $options, bool $detachedRun = false)
     {
+        $controller = $this->createController($info);
+
+        if ($desc = $options['description'] ?? '') {
+            $controller::setDescription($desc);
+        }
+
+        if ($detachedRun) {
+            $controller->setDetached();
+        }
+
+        // Command method, no suffix
+        return $controller->run($info['action']);
+    }
+
+    /**
+     * @param string $name
+     *
+     * @return Controller
+     */
+    public function getController(string $name): Controller
+    {
+        $info = $this->router->getControllerInfo($name);
+        if (!$info) {
+            throw new RuntimeException('the group controller not exist. name: ' . $name);
+        }
+
+        $info['group'] = $name;
+        return $this->createController($info);
+    }
+
+    /**
+     * @param array $info
+     *
+     * @return Controller
+     */
+    protected function createController(array $info): Controller
+    {
+        $group = $info['group']; // The group name
+        if (isset($this->groupObjects[$group])) {
+            $this->debugf('load the "%s" controller object form cache', $group);
+            return $this->groupObjects[$group];
+        }
+
+        $this->debugf('create the "%s" controller object and cache it', $group);
+
         /** @var Controller $handler */
+        $handler = $info['handler']; // The controller class or object
         if (is_string($handler)) {
             $class = $handler;
-
             if (!class_exists($class)) {
                 Helper::throwInvalidArgument('The console controller class [%s] not exists!', $class);
             }
@@ -387,17 +431,11 @@ protected function runAction(string $group, string $action, $handler, array $opt
 
         // force set name and description
         $handler::setName($group);
-        if ($desc = $options['description'] ?? '') {
-            $handler::setDescription($desc);
-        }
-
         $handler->setApp($this);
         $handler->setDelimiter($this->delimiter);
 
-        if ($detachedRun) {
-            $handler->setDetached();
-        }
-
-        return $handler->run($action);
+        // cache object
+        $this->groupObjects[$group] = $handler;
+        return $handler;
     }
 }

src/Controller.php

@@ -563,7 +563,7 @@ protected function getAllCommandMethods(ReflectionClass $ref = null, bool $onlyN
      *
      * @return string
      */
-    protected function getRealCommandName(string $name): string
+    public function getRealCommandName(string $name): string
     {
         if (!$name) {
             return '';

src/Router.php

@@ -375,6 +375,16 @@ public function getControllers(): array
         return $this->controllers;
     }
 
+    /**
+     * @param $name
+     *
+     * @return array
+     */
+    public function getControllerInfo(string $name): array
+    {
+        return $this->controllers[$name] ?? [];
+    }
+
     /**
      * @param $name
      *